fix(startup): show correct Vite client URL in dev mode#101
Merged
justinchoo93 merged 1 commit intomainfrom Feb 27, 2026
Merged
Conversation
resolveVisitPort checked NODE_ENV === 'development' but dev scripts never set NODE_ENV, so the startup URL always showed the Express port (3001) instead of the Vite port (5173). Align with the rest of the codebase by checking !== 'production'. Also add a dev mode hint line clarifying which port is the client vs the server. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
resolveVisitPortcheckedNODE_ENV === 'development'but dev scripts never setNODE_ENV, so the startup URL always pointed to the Express port (3001) instead of the Vite client port (5173)!== 'production'Test plan
startup-url.test.tswith corrected expectations for unset/test NODE_ENV🤖 Generated with Claude Code