Skip to content

Conversation

@Tal500
Copy link
Contributor

@Tal500 Tal500 commented May 21, 2025

  • Include also another integration test function to check header in parent dir usage (that was failing in previous commit).
  • Add a safety check that we did not meet the header file that we are about to insert to the map (abort with stderr message otherwise) - this not only detect unmet bugs in including paths, but also avoid memory leak.
  • Add much more cover in the test functions, and check more details.

Tal500 added 3 commits May 21, 2025 13:06
…echanics

Include also another integration test function to check header in parent dir usage (was failing before)
@Tal500 Tal500 force-pushed the fix-parent-relative-path branch from 48cff47 to 4d4bab8 Compare May 21, 2025 12:01
@Tal500 Tal500 marked this pull request as draft May 21, 2025 16:43
Copy link
Owner

@danmar danmar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

some comments. I didn't check it all carefully yet.

@Tal500 Tal500 marked this pull request as ready for review May 22, 2025 10:24
Copy link
Owner

@danmar danmar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

small question. partial review.

@Tal500
Copy link
Contributor Author

Tal500 commented May 30, 2025

I read your comments and reply in the code context.
I do think that even if you want to have a fine graded internal testing, you shall first merge this PR and introduce in a new PR the new extra internal unitest system.

@danmar danmar merged commit 76df97f into danmar:master May 30, 2025
16 checks passed
@Tal500 Tal500 deleted the fix-parent-relative-path branch June 12, 2025 12:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants