Merged
Conversation
Owner
|
Hey @harrisonritz I'm finally getting around to this, and have spotted a few bugs that need fixes. Given that you submitted this awhile ago, if it's alright with you I can just add in the fixes directly to this PR rather than reviewing + requesting changes. Would save you time instead of making you revisit the whole thing and have you add fixes. Lmk |
Contributor
Author
|
Sweet! Ya, feel free to add yourself, don’t need to keep me in the loop.
Harrison
From: Dan Gale ***@***.***>
Date: Monday, December 19, 2022 at 12:19 PM
To: danjgale/surfplot ***@***.***>
Cc: Harrison Ritz ***@***.***>, Mention ***@***.***>
Subject: Re: [danjgale/surfplot] add alpha parameter (PR #14)
Hey @harrisonritz<https://github.com/harrisonritz> I'm finally getting around to this, and have spotted a few bugs that need fixes. Given that you submitted this awhile ago, if it's alright with you I can just add in the fixes directly to this PR rather than reviewing + making you add them. Lmk
—
Reply to this email directly, view it on GitHub<#14 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AEDVTHZBAOOXGF6GTEEAMX3WOCKJZANCNFSM5RUKGDSA>.
You are receiving this because you were mentioned.Message ID: ***@***.***>
|
Owner
|
Great thanks! Can you click "Allow edits from maintainers"? |
Contributor
Author
|
looks like this is checked already. |
Owner
|
All looks good now. Thanks for your contribution @harrisonritz! |
Contributor
Author
|
np! sorry for being shit at python haha the colons kill me |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
takes argument for colormap opacity. Will break if alpha < 0, but doc + error is informative.