fix(skills,install): alias quoting, binding cascade, silent CLEAN, two eval defects - #1739
Open
elhoim wants to merge 7 commits into
Open
fix(skills,install): alias quoting, binding cascade, silent CLEAN, two eval defects#1739elhoim wants to merge 7 commits into
elhoim wants to merge 7 commits into
Conversation
The alias body interpolated $LAUNCHER/$SYS_PROMPT unquoted, so a $HOME with a space broke the launcher and one with a quote corrupted the rc file — and the awk pass has already commented out the working old alias by then, leaving the user with no alias at all. Both shipped copies updated.
…kill It walked all of configRoot/skills running bun install in every directory with a package.json, touching pre-existing user skills and double-installing the payload copy; failures land in blockers, so the documented offline install exited 1. Both shipped copies updated.
A single forward pass left the start binding dangling when the target shape was removed. Reproducible with the tool's own validate: "binding:shape-a-start: dangling binding" before, valid after.
The verification decode's exit status was unchecked, so on failure it certified a file it had never scanned and exited 0.
An unguarded JSON.parse threw after all eight fetchers had already succeeded, so a trailing comma discarded the entire digest.
The only shipped suite is still the v1 `tasks:` format, so every run died on `for (const c of undefined)`; callers that catch broadly turned that into a regression eval which silently never ran. No v1→v2 translation is attempted: UseCases/*.yaml define weighted graders and carry no prompt, so there is nothing for this single-shot runner to send.
passed/trials reported 2-of-3 as 67% where the true pass^k is 0, making a flaky case look mostly-passing.
elhoim
force-pushed
the
fix/skills-installer
branch
from
August 3, 2026 07:01
1979e1e to
23f7df8
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
7 commits, one per fix, so each can be cherry-picked independently. Each was verified to apply cleanly onto
47df8eeby itself.383d20a59e66272cacf0fd4cbd2f911c78ec6d1c0b23f7df8Seven defects across the skills payload and the installer.
install.sh:314(and its mirror atskills/LifeOS/install/install.sh) — the alias body interpolated$LAUNCHER/$SYS_PROMPTunquoted. A$HOMEwith a space breaks the launcher; one with a quote corrupts the rc file. By that point the awk pass has already commented out the working old alias, so the failure leaves the user with no alias. Addsshq()and quotes both parse levels. Tested with paths containing a space, a single quote, and a$(…)substitution: all four round-trip identically and nothing executes.skills/Tldraw/Tools/Tldr.ts:272— a single forward pass over bindings leaves thestartbinding dangling when the target shape is removed. Reproduced with the tool's ownvalidate:INVALID: binding:shape-a-start: dangling bindingbefore,validafter (3 records removed vs 4). Iterates to a fixpoint.skills/AudioEditor/Tools/GateRepair.ts:185— the verification decode's exit status was unchecked, so on decode failure it printedCLEANand exited 0, certifying a file it never scanned.skills/LocalIntelligence/Tools/UserSources.ts:88— unguardedJSON.parse; a trailing comma in the user'ssources.jsonaborted the run after all eight fetchers had succeeded, so nothing was persisted.skills/Evals/Tools/EvalRunner.ts:133—for (const c of suite.cases)throws a bareTypeError, because the only shipped suite (Suites/Regression/core-behaviors.yaml) is still the legacy v1tasks:format. Callers that catch broadly turned that into a regression eval that silently never ran. I did not write a v1→v2 translation layer:UseCases/*.yamldefine weighted graders and carry noprompt, so there is nothing for this single-shot runner to send, and guessing at the intended mapping seemed worse than a precise error. Before:TypeError: undefined is not an object (evaluating 'suite.cases'). After: a message naming the format, the 4 tasks, and the two ways forward.skills/Evals/Tools/EvalRunner.ts:149—pass_to_k = passed/trialsis a mean, not pass^k: 2-of-3 reported 67% where the true pass^k is 0, making a flaky case look mostly-passing.skills/LifeOS/Tools/DeployCore.ts:277(and its mirror atLifeOS/Tools/DeployCore.ts) — walked all ofconfigRoot/skillsrunningbun installin every dir with apackage.json, touching pre-existing user skills and double-installing the payload copy; failures land inblockers, so the documented offline install exits 1.DeployCore.tsandinstall.share each shipped in two copies. Both copies were identical at47df8eeand both are updated here — a payload file fixed in one copy and left broken in the other is its own defect.Testing. Commands and output are in the per-file notes above. I did not do a fresh-system install verification (contributing step 3) — these are targeted fixes verified per-file, not an install run.