fix: fix #1080 doing a wrong calc()

[te6-in]

Summary by CodeRabbit

• 스타일
  • 여백 관련 CSS 속성의 단위 표기법을 업데이트했습니다.

_{✏️ Tip: You can customize this high-level summary in your review settings.}

[changeset-bot]

⚠️ No Changeset found

Latest commit: 26f54aa

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

[coderabbitai]

Walkthrough

CSS 커스텀 프로퍼티의 기본값을 단위 없는 영(0)에서 픽셀 단위를 가진 영(0px)으로 변경했습니다. 전역 설정과 액션 버튼 레시피의 블리드 관련 변수들이 일관된 CSS 단위 문법으로 업데이트되었습니다.

Changes

분류 / 파일	변경 요약
CSS 단위 정규화 packages/qvism-preset/src/global.ts, packages/qvism-preset/src/recipes/action-button.ts	블리드 CSS 커스텀 프로퍼티(--seed-box-bleed-top, --seed-box-bleed-bottom, --seed-box-bleed-left, --seed-box-bleed-right) 기본값을 "0"에서 "0px"로 변경하여 단위 일관성 개선

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

• 검토 포인트: CSS 커스텀 프로퍼티 값 변경이 의존하는 margin 계산들에서 의도된 동작을 유지하는지 확인 필요

Poem

🐰 영(零)에 픽셀 옷을 입혀,

CSS의 옷맞춤을 다시 하네요.

단위의 조화, 반짝반짝하고,

계산은 여전히 완벽하게 동작해요! ✨

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	PR 제목이 변경 사항의 주요 내용과 관련이 있으나, 구체적인 수정 내용을 명확히 설명하지 못함. 'wrong calc()' 표현이 모호하고, 실제 변경은 단위 없는 0을 0px로 변경하는 것인데 제목에서 이를 명확히 드러내지 않음.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✨ Finishing touches

• 📝 Generate docstrings

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment
• Commit unit tests in branch fix/fix-1080

---

📜 Recent review details

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Disabled knowledge base sources:

• Jira integration is disabled by default for public repositories
• Linear integration is disabled by default for public repositories

You can enable these sources in your CodeRabbit configuration.

📥 Commits

Reviewing files that changed from the base of the PR and between 8f31f93 and 26f54aa.

⛔ Files ignored due to path filters (5)

• packages/css/all.css is excluded by !packages/css/**/*
• packages/css/all.min.css is excluded by !packages/css/**/*
• packages/css/base.css is excluded by !packages/css/**/*
• packages/css/base.min.css is excluded by !packages/css/**/*
• packages/css/recipes/action-button.css is excluded by !packages/css/**/*

📒 Files selected for processing (2)

• packages/qvism-preset/src/global.ts (1 hunks)
• packages/qvism-preset/src/recipes/action-button.ts (1 hunks)

🧰 Additional context used

📓 Path-based instructions (2)

**/*.{ts,tsx}

📄 CodeRabbit inference engine (.cursor/rules/docs.mdc)

**/*.{ts,tsx}: Use descriptive variable names with auxiliary verbs (e.g., isLoading, hasError)
Structure files: exported component, subcomponents, helpers, static content, types
Favor named exports for components
Use TypeScript for all code; prefer interfaces over types
Avoid enums; use maps instead
Use the "function" keyword for pure functions
Avoid unnecessary curly braces in conditionals; use concise syntax for simple statements

Files:

• packages/qvism-preset/src/global.ts
• packages/qvism-preset/src/recipes/action-button.ts

packages/qvism-preset/**

📄 CodeRabbit inference engine (.cursor/rules/overview.mdc)

The packages/qvism-preset directory contains component CSS recipe definitions

Files:

• packages/qvism-preset/src/global.ts
• packages/qvism-preset/src/recipes/action-button.ts

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (2)

• GitHub Check: chromatic-deployment
• GitHub Check: Deploy Seed Design V3 Docs

🔇 Additional comments (2)

packages/qvism-preset/src/global.ts (1)

126-133: CSS calc() 단위 일관성 수정 승인

블리드 변수에 명시적인 픽셀 단위(0px)를 추가하여 CSS calc() 계산의 단위 일관성을 개선했습니다. 이 변수들이 실제 픽셀 값으로 재정의될 때 calc(var(...) * -1) 표현식이 올바르게 작동하도록 보장합니다.

packages/qvism-preset/src/recipes/action-button.ts (1)

41-48: LGTM! calc() 단위 일관성 개선

global.ts의 변경 사항과 일관되게 블리드 변수에 명시적인 픽셀 단위를 추가했습니다. 액션 버튼 레시피가 전역 스타일과 동일한 단위 규칙을 따르도록 보장합니다.

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[cloudflare-workers-and-pages]

Deploying seed-design-v3 with    Cloudflare Pages

Latest commit:	26f54aa
Status:	✅  Deploy successful!
Preview URL:	https://ff95bcb5.seed-design.pages.dev
Branch Preview URL:	https://fix-fix-1080.seed-design.pages.dev

View logs