Duru/readd and fix #47
Conversation
|
|
||
| // Both | ||
| // case Basketball | ||
| case Basketball |
There was a problem hiding this comment.
can we clean this up a bit? I think a cleaner approach would look closer to this:
enum Sport: String, Identifiable, CaseIterable, CustomStringConvertible {
var id: Self { self }
case all = "All"
case basketball = "Basketball"
case iceHockey = "Ice Hockey"
case lacrosse = "Lacrosse"
case soccer = "Soccer"
case fieldHockey = "Field Hockey"
case baseball = "Baseball"
case football = "Football"
}
| case All | ||
|
|
||
| // Both | ||
| // case Basketball |
| case .Baseball: return game.timeUpdates.count > 3 ? game.timeUpdates.count - 2 : 10 | ||
| // the last three columns are total runs, hits, and errors | ||
| // if backend stores null for scoreBreakdown, display regular score box with 10 columns | ||
| case .Basketball: |
There was a problem hiding this comment.
No need for comments for each sport, you should remove those. Additionally, you should be consistent about the indentation here. I think a good practice is doing it inline when you have singular value, and nesting it when you're performing computations. Additionally, swift has implicit returns for things like this, so your code would be a lot cleaner without the returns here!
Xhether
left a comment
There was a problem hiding this comment.
Just some small stying issues I addressed in the comments, but great work! I'll approve ASAP after you fix those
|
Very small changes:
1. Also to the past scores part with basketball having a different number of periods thus columns for men and women