Skip to content

Conversation

@joshwnj
Copy link
Member

@joshwnj joshwnj commented Aug 3, 2015

If we want to require css from something in node_modules we need to use the global: true transform option (https://github.com/substack/node-browserify/#btransformtr-opts)

Example: the import-node-module case will fail by default, and will pass if we set transform options of { global: true }

@joshwnj
Copy link
Member Author

joshwnj commented Aug 3, 2015

Btw this doesn't cover if you want to composes: foo from "cool-styles/styles.css". I've got it mostly working locally but will wait for this one to merge before I add it.

joshgillies added a commit that referenced this pull request Aug 3, 2015
Enable transforming of files in node_modules
@joshgillies joshgillies merged commit 077b1bf into master Aug 3, 2015
@joshgillies
Copy link
Member

Solid! 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants