Add discoverable deeplink for invite acceptance WAYF#163
Merged
michielbdejong merged 6 commits intodevelopfrom Jan 16, 2025
Merged
Add discoverable deeplink for invite acceptance WAYF#163michielbdejong merged 6 commits intodevelopfrom
michielbdejong merged 6 commits intodevelopfrom
Conversation
Member
|
Nice, and can you also add it to |
glpatcern
approved these changes
Jan 9, 2025
Member
glpatcern
left a comment
There was a problem hiding this comment.
Looks good, I have a couple of mostly cosmetic comments plus one sentence to recommend this when exposing the invites cap.
Co-authored-by: Giuseppe Lo Presti <giuseppe.lopresti@cern.ch>
Co-authored-by: Giuseppe Lo Presti <giuseppe.lopresti@cern.ch>
Co-authored-by: Giuseppe Lo Presti <giuseppe.lopresti@cern.ch>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.