Skip to content

Document Workspace.Config asymmetry: full vs minimal after Attach #16

@bilby91

Description

@bilby91

Engine.Up returns a *Workspace with Config populated from Resolve. Engine.Attach returns a *Workspace whose Config is reconstructed from container labels and inspect output (labels.go::configFromContainerLabels) — only LocalWorkspaceFolder, ContainerWorkspaceFolder, ContainerUser are populated. Other fields (Lifecycle, Mounts, Customizations, etc.) are zero values.

This is enough to drive the substituter (Exec works), but a caller reading ws.Config.Lifecycle after Attach will see empty phases. Document the asymmetry on Workspace.Config and Engine.Attach GoDoc.

Possibly: add a sentinel field like Config.Partial bool so callers can detect they got the minimal form.

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    No type
    No fields configured for issues without a type.

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions