Make tx gas limit configurable in driver#3780
Merged
squadgazzz merged 6 commits intomainfrom Oct 17, 2025
Merged
Conversation
Required to fix Sepolia after fusaka hard fork.
jmg-duarte
approved these changes
Oct 16, 2025
Contributor
jmg-duarte
left a comment
There was a problem hiding this comment.
nit, but it's g2g due to the urgency IMO
Comment on lines
+51
to
+52
| /// Transaction gas limit | ||
| /// If not specified, uses current block's gas limit |
Contributor
There was a problem hiding this comment.
Suggested change
| /// Transaction gas limit | |
| /// If not specified, uses current block's gas limit | |
| /// Transaction gas limit. | |
| /// If not specified, it uses current block's gas limit. |
squadgazzz
reviewed
Oct 16, 2025
| /// Transaction gas limit | ||
| /// If not specified, uses current block's gas limit | ||
| #[clap(long, env)] | ||
| pub tx_gas_limit: Option<U256>, |
Contributor
There was a problem hiding this comment.
Maybe we should be a bit more specific with the naming, since it is used only for the creation of access lists. Are there any other places where we set the gas limit in this crate and should we also switch to the same config param?
Contributor
Author
There was a problem hiding this comment.
I have checked the driver's source code and found no other instances where we specify the tx gas limit. It is only related to the creation of access lists.
squadgazzz
previously approved these changes
Oct 16, 2025
Contributor
squadgazzz
left a comment
There was a problem hiding this comment.
LGTM. Shouldn't be merged until an infra PR is ready.
m-sz
added a commit
that referenced
this pull request
Oct 17, 2025
# Description Required for tx gas configuration to be backwards compatible and guarantee smooth deployment. The infrastructure will be able to set tx gas limit per chain, but unless this field is expected, the driver would just panic on parsing the config. This introduces the required field as an option, and does not do anything with the value if set. #3780 will actually make it mandatory and work.
squadgazzz
approved these changes
Oct 17, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Required to fix Sepolia after fusaka hard fork.
Description
Sepolia got broken because the fusaka hard fork introduced a protocol level cap on tx gas limit which currently is being set to the block gas limit (which is too high).
Changes
Make tx gas limit configurable in the driver, preserving the old behaviour (of taking block gas limit) if it is not specified.
How to test
Related Issues
Fixes #3777