rhcos-toolbox: update to mirror containers/toolbox

[prestist]

A bug was reported downstream while installing dnf package in toolbox resutled in OStree issue.
Follow containers/toolbox configuration to avoid this error.

Relates to: https://issues.redhat.com/browse/OCPBUGS-56964

[prestist]

The /run subdirectory changes are the critical fix for OCPBUGS-56964, the other changes are to mirror upstream containers/toolbox.

[travier]

LGTM. Can you link to where you found the options that containers/toolbox uses? Thanks

[prestist]

I talked to @aaradhak during standup and he was running into issues with -dns none\

Im not sure if we should mirror the entirety of the arguments that containers/toolbox uses, as a lot of them are conditional and distilling them into a flat object like this is going to cause issues.

The bug would be fixed just with the explicit run bind mounts so I am thinking about dropping all else as it might introduce issues depending on env.

https://github.com/containers/toolbox/blob/main/src/cmd/create.go#L426
https://github.com/containers/toolbox/blob/main/src/cmd/create.go#L450

[aaradhak]

-dns none
The DNS resolution inside the toolbox container made it impossible to install packages

With regards to volume mounts for directories, I encountered few errors for the directories mentioned

podman create fails with:
Error: statfs /run/systemd/resolve: no such file or directory
Error: statfs /var/lib/flatpak: no such file or directory

  --volume /run/libvirt:/run/libvirt \            
  --volume /run/systemd/resolve:/run/systemd/resolve \ 
  --volume /var/lib/flatpak:/var/lib/flatpak \      
  --volume /var/lib/libvirt:/var/lib/libvirt \   
  

I talked to @aaradhak during standup and he was running into issues with -dns none\

Im not sure if we should mirror the entirety of the arguments that containers/toolbox uses, as a lot of them are conditional and distilling them into a flat object like this is going to cause issues.

The bug would be fixed just with the explicit run bind mounts so I am thinking about dropping all else as it might introduce issues depending on env.

https://github.com/containers/toolbox/blob/main/src/cmd/create.go#L426 https://github.com/containers/toolbox/blob/main/src/cmd/create.go#L450

[prestist]

@aaradhak can you test the latest for me and let me know if this enables dnf but not issues this time ?

[aaradhak]

Sure will run another test

[aaradhak]

I tested it again and the dnf install seemed to work without any issue.