Migrate to webpack v5#1225
Closed
Yasamato wants to merge 6 commits into
Closed
Conversation
Contributor
Author
|
I would like to hear your opinion @cookpete regarding my attempts to upgrade everything. I couldn't find anything that broke after my adjustments and am open to suggestions. |
Yasamato
added a commit
to Yasamato/react-player
that referenced
this pull request
Apr 30, 2021
As mentioned in cookpete#1225 `findDOMNode` is deprecated.
Owner
|
Funnily enough I was considering moving everything to a |
Contributor
Author
|
I am myself not really familiar with bundling and publishing myself. But if it can be done vie |
cookpete
added a commit
that referenced
this pull request
Feb 20, 2022
* Adjust listener for kaltura Fixes #1202 and related to #1082. * Fix lint As mentioned in #1225 `findDOMNode` is deprecated. * Add autoplay to iframe props * Move code to load method and call it instead * Update src/players/Kaltura.js Co-authored-by: Pete Cook <pete@cookpete.com> * Remove `this.load()` call in `componentDidMount` Co-authored-by: Pete Cook <pete@cookpete.com>
Collaborator
|
closed by #1684 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Migrated to webpack v5 from v4 and upgraded dependencies to latest.
yarn outdatedlisted:Deps-changes
postcss-loaderandpostcss-nested>=5 devDependencypostcss>=8 had to be added to devDepDemo App
webpack-dev-serverdeprecated and should now be called viawebpack servefindDOMNodehas been long deprecated, needed to adjust fullscreen example in demoimport { version } from '../../package.json'throws warning:Should not import the named export 'version' (imported as 'version') from default-exporting module (only default export is available soon), replaced it withimport metadata from '../../package.json'ts lint with react
React now requires (or strongly encourages you) to use null safety, added to
.tsconfigwebpack config
queryproperty has been removed from v5 and replaced it with usequery-string like loader
'file-loader?name=assets/[hash].[ext]'is disallowed, moved it to use propertyTerserPluginoptionsourceMaphas been restructured and needed to be moved toterserOptionsdefault versions
hls
0.14.16->1.0.2dash
3.1.3->3.2.2flv already up to date
adjusted notice in
README.mdFixes #1215
Other deprecation warning:
(node:8465) [DEP_WEBPACK_COMPILATION_OPTIMIZE_CHUNK_ASSETS] DeprecationWarning: optimizeChunkAssets is deprecated (use Compilation.hooks.processAssets instead and use one of Compilation.PROCESS_ASSETS_STAGE_* as stage option)