Skip to content

chore: bump chart.js and fix font weight type#5789

Merged
Lisa White (whitelisab) merged 2 commits into
masterfrom
chore/update-chartjs
Dec 20, 2023
Merged

chore: bump chart.js and fix font weight type#5789
Lisa White (whitelisab) merged 2 commits into
masterfrom
chore/update-chartjs

Conversation

@whitelisab

Copy link
Copy Markdown
Contributor

Purpose

Dependabot tried to update the Chart.js dependency in GA4 and the update failed: #5663

Approach

Chart.js version 4.4.1 changes the type of font weight from string to number (see this PR). This PR bumps the package and then changes the font weight for the line chart from a string to a number.

Note: I did change the tooltip font weight from 700 to the fontWeightDemiBold token (which equates to 600), and I still think it looks ok, see screenshot.

Screenshot 2023-12-19 at 4 31 58 PM

Testing steps

I verified that the line chart still renders correctly in the GA4 app sidebar.

Breaking Changes

Dependencies and/or References

https://github.com/chartjs/Chart.js/releases/tag/v4.4.1
chartjs/Chart.js#11605
#5663

Deployment

dependabot Bot and others added 2 commits December 19, 2023 16:20
Bumps [chart.js](https://github.com/chartjs/Chart.js) from 4.4.0 to 4.4.1.
- [Release notes](https://github.com/chartjs/Chart.js/releases)
- [Commits](chartjs/Chart.js@v4.4.0...v4.4.1)

---
updated-dependencies:
- dependency-name: chart.js
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
@whitelisab
Lisa White (whitelisab) requested a review from a team as a code owner December 19, 2023 23:34
@netlify

netlify Bot commented Dec 19, 2023

Copy link
Copy Markdown

Deploy Preview for ecommerce-app-base-components canceled.

Name Link
🔨 Latest commit 2eebfcb
🔍 Latest deploy log https://app.netlify.com/sites/ecommerce-app-base-components/deploys/65822882a40a1b0008387f1f

@whitelisab
Lisa White (whitelisab) merged commit de2d309 into master Dec 20, 2023
@whitelisab
Lisa White (whitelisab) deleted the chore/update-chartjs branch December 20, 2023 14:52
Shannon Grice (snowdoniadarkness) referenced this pull request in citizenwatchamerica/citizen-contentful-apps Jul 7, 2026
* fix(deps): bump chart.js from 4.4.0 to 4.4.1

Bumps [chart.js](https://github.com/chartjs/Chart.js) from 4.4.0 to 4.4.1.
- [Release notes](https://github.com/chartjs/Chart.js/releases)
- [Commits](chartjs/Chart.js@v4.4.0...v4.4.1)

---
updated-dependencies:
- dependency-name: chart.js
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>

* fix: update chart font weight to number

---------

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants