Skip to content

go.mod: github.com/opencontainers/image-spec v1.1.0, golang.org/x/sys v0.26.0 #15

Merged
AkihiroSuda merged 2 commits into
containerd:mainfrom
AkihiroSuda:dev
Oct 26, 2024
Merged

go.mod: github.com/opencontainers/image-spec v1.1.0, golang.org/x/sys v0.26.0 #15
AkihiroSuda merged 2 commits into
containerd:mainfrom
AkihiroSuda:dev

Conversation

@AkihiroSuda
Copy link
Copy Markdown
Member

No description provided.

Signed-off-by: Akihiro Suda <akihiro.suda.cz@hco.ntt.co.jp>
Signed-off-by: Akihiro Suda <akihiro.suda.cz@hco.ntt.co.jp>
Comment thread go.mod
github.com/opencontainers/image-spec v1.1.0
github.com/stretchr/testify v1.8.4
golang.org/x/sys v0.10.0
golang.org/x/sys v0.26.0
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was there a specific reason for updating this one? Actually wondering if we could drop this dependency as a whole. It looks like we only use it for Uname()

err := unix.Uname(&uname)

which is also provided by stdlib syscall; https://pkg.go.dev/syscall#Uname

If there's no difference between the two, we may as well reduce dependencies here (as its a library module, so good to reduce dependencies where possible)

WDYT?

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was there a specific reason for updating this one?

No

It looks like we only use it for Uname()

Doesn't seem so

major, minor, build := windows.RtlGetNtVersionNumbers()

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ah! sorry, looked at the linux part only. Yeah, that's a pity.

@AkihiroSuda AkihiroSuda requested a review from thaJeztah October 22, 2024 01:19
@AkihiroSuda AkihiroSuda merged commit a413568 into containerd:main Oct 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants