Resize fifo to 1024K

[kkkkun]

The container which writes logs synchronously would be blocked in the following scenarios:

1. Container writes logs synchronously to stdout or stderr .
2. Upgrade containerd and speed a lot of time.

So it is important to resize fifo in container runtime. After commit, the pipe_max_size had adjusted to 1024K.

[kkkkun]

/assign @thaJeztah

[thaJeztah]

GitHub actions looks to have purged logs for the previous run, but I think the linter may have been complaining about this, and likely wants them to be combined;

const (
	F_SETPIPE_SZ = 1031
	FIFO_SIZE = 1024 * 1024
)

And as both are only used internally, it's better to not export them; perhaps use camelCase to make linters happy, but you can refer to the upstream counterpart for these, e.g.

// Sizes here match what's defined in the kernel; see https://github.com/torvalds/linux/commit/ff9da691c0498ff81fdd014e7a0731dab2337dac
const (
	fsetPipeSize = 1031        // F_SETPIPE_SZ
	fifoSize     = 1024 * 1024 // FIFO_SIZE
)

I'm also curios if these are consts that would make sense to be included in golang.org/x/sys - this PR is making changes assuming Linux, but the file is used for other unix-y platforms; would this be problematic for any of the other flavours (macOS, freeBSD)? /cc @samuelkarp

[kkkkun]

The failed tests seem not to be related to the change.

[thaJeztah]

The failed tests seem not to be related to the change.

Hm.. interesting; linting failure I suspect is because of an old version of GolangCI-lint, which is not yet aware of the max builtin? Not sure why that only shows up now.

Running [/home/runner/golangci-lint-1.51.1-linux-amd64/golangci-lint run --out-format=github-actions --path-prefix=src/github.com/containerd/fifo] in [/home/runner/work/fifo/fifo/src/github.com/containerd/fifo] ...
  Error: undefined: max (typecheck)
  
  Error: issues found

Don't know about the other one (I'm not too familiar with all of this repository);

=== RUN   TestFifoCloseWhileReadingAndWriting
    fifo_test.go:450: 
        	Error Trace:	/home/runner/work/fifo/fifo/src/github.com/containerd/fifo/fifo_test.go:450
        	Error:      	An error is expected but got nil.
        	Test:       	TestFifoCloseWhileReadingAndWriting
    fifo_test.go:454: Read should not succeed
--- FAIL: TestFifoCloseWhileReadingAndWriting (0.50s)

[thaJeztah]

Can you rebase your PR? #58 should have fixed the CI failures

[kkkkun]

Can you rebase your PR? #58 should have fixed the CI failures

Done. I do not understand the failed test.

=== RUN   TestFifoCloseWhileReadingAndWriting
    fifo_test.go:450: 
        	Error Trace:	/home/runner/work/fifo/fifo/src/github.com/containerd/fifo/fifo_test.go:450
        	Error:      	An error is expected but got nil.
        	Test:       	TestFifoCloseWhileReadingAndWriting
    fifo_test.go:454: Read should not succeed
--- FAIL: TestFifoCloseWhileReadingAndWriting (0.50s)

[dcantah]

It's a shame that the api surface returns a ReadWriteCloser directly, otherwise I'd say why don't we just expose a method that lets you set the buffer size to whatever you want. Alternatively, we could expose a new constructor, like OpenFifoWithOpts() where we can pass in options to control things like this. My opinion is it should be the users choice, and we shouldn't automatically set the buf size for them if possible.