Enable reloading of views even if state / URL has not changed#21
Open
lee-borsboom wants to merge 1 commit intomasterfrom
Open
Enable reloading of views even if state / URL has not changed#21lee-borsboom wants to merge 1 commit intomasterfrom
lee-borsboom wants to merge 1 commit intomasterfrom
Conversation
e9a7b91 to
85e6919
Compare
Contributor
Author
|
Infinite loop fixed... was caused because the list pages call Route.go when they load - they were relying on the fact that the router didn't reload when nothing had changed, but in this PR I'd defaulted Route.go to force a reload. Default is now forceReload = false. I think force reloading is a more intuitive default and could be combined with some route-href/route-on-click updates to fix the issue we have where clicking the main navigation links doesn't reload the view. Before we can do that we need to update (at least) our list pages though, so I'll defer that for now... |
85e6919 to
203ac9f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.