Add Go modules to vendor directory

[chris-crone]

Chatting to @thaJeztah and @justincormack, for things that we expect to ship as a binary it makes more sense to include the modules as vendored code.

This also speeds up the build for the CI as we don't need to fetch anything.

[ndeloof]

This also speeds up the build for the CI as we don't need to fetch anything.

But you have to checkout vendor/, which will later include all previous versions of your dependencies with your git history, while go runtime on CI nodes could benefit go mod cache for same purpose.

[ndeloof]

-0

[chris-crone]

It actually appears that you do need the GOFLAGS=-mod=vendor as otherwise the modules are pulled.

[thaJeztah]

SGTM

@tonistiigi ptal (you dealt with go mod a bit more than I did)

[thaJeztah]

One thing to consider (no blocker) is if we want this to always be run, or only if either the Go version is updated, or if go.mod or vendor/ has been modified in a pull request

[chris-crone]

Tonis didn't have access to this GitHub org. I've added him and will re-ping when he's accepted.

[ulyssessouza]

LGTM