Skip to content

consider removing hasOwnProperty when cloning objects #1

@matthewmueller

Description

@matthewmueller

This check causes issues when you try to clone class instances:

Example:

function Datepicker(cls) {
  if(!(this instanceof Datepicker)) return new Datepicker(cls);
  this.className = cls;
}

Datepicker.prototype.toString = function() {
  return this.className;
};

var datepicker = Datepicker('date')
datepicker.toString() // date
datepicker = clone(datepicker); // { className: "date" };
datepicker.toString() // [object Object]

basically, the toString method on the prototype isn't getting copied over. I also noticed underscore doesn't have this check when run _.clone, so it works as expected.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions