half-azer, jungle, and tundra dwarves

[JayPea00101010]

I think this works as a request, (fingers crossed)
As well as adding the XML for the subraces I've added a .index file for races from r/UA

[JayPea00101010]

for this file to work properly the following pull request also needs to be approved
aurorabuilder/elements#384

[JayPea00101010]

aurorabuilder/elements#351
closes this content request

[JayPea00101010]

typos and not changing files strikes again
I've fixed those now though and also fixed not putting .xml in the file location

[swdriessen]

Be sure to test the files before you submit the pull request, this makes it easier for the person who needs to check and test it.
I'd suggest you create characters for the content you create at a high enough level of the highest fetaure in the content (level 3 in this case). Then when you generate a sheet you should see all the features / traits that you expect.

[NickVendel]

Okay, i have one issue (for now) with this pull, why do you put Reddit: DnD inside reddit-unearthed-arcana.index?

[JayPea00101010]

I've now fixed that

[ColdAnkles]

So, on the filename - I think it should be probably "dwarf-TheArenaGuy.xml".
Prepending it with subrace is redundnant, so I think mentioning dwarf makes sense.
Unless you split them in to individual files for each subrace? "dwarf-jungle.xml" & etc.
Ultimately all it needs is to be is clear where a subrace is coming from so if a file needs updating due to errors or changes to Aurora, its obvious which file is for what on name alone.

[JayPea00101010]

That makes sense, I was avoiding having them as multiple files given its all th same source though i guess that would work too.
I'll change it to "dwarf-TheArenaGuy.xml" when I can

[JayPea00101010]

ok pretty sure I've changed it where it needs changing, probably helpful for someone else to double check it though

[NickVendel]

Prepending it with subrace is redundnant, so I think mentioning dwarf makes sense.
Unless you split them in to individual files for each subrace? "dwarf-jungle.xml" & etc.

I have few things to say about that:

1. there's nothing wrong with doing subraces-dwarf.xml, even if you can't find subraces inside original repository.

Ultimately all it needs is to be is clear where a subrace is coming from so if a file needs updating due to errors or changes to Aurora, its obvious which file is for what on name alone.

2. I find this point incredibly useless, since when you get an error on app loading, it will usually point to the file that has issues (alternatively it will not point at any file at all). And if you get errors while using it, error will not display name of the file anyway.
   File has a url to point where it coming from. You could also force the use of "url setters", that will link elements and url links under description in the app to proper source, rather than just throwing people to Reddit or different subreddits.
3. If you say it should be clear, and you want to use this structure of [race/class/etc.]-[author].xml, then you should do it for already existent content too, so to not hold other people to different standards of structuring. And to prevent a mess of people doing different things in different folders.

[JayPea00101010]

ok so I've now updated the file name again, should all be good now

[ColdAnkles]

I think this is fine to go now. Anyone else have comments/suggestions?

[ColdAnkles]

Tried to remove the u-a change to stop it from appearing in this PR, no such luck :(

[JayPea00101010]

tried to remove the what?

[ColdAnkles]

"files changed" shows that " reddit/reddit-unearthed-arcana.index " was edited to remove a line ending... or add one? unrelated to the PR since you changed it to r/DnD

[JayPea00101010]

ok so in trying to fix it I've completely screwed it up

[JayPea00101010]

note to self, never try to fix things like this again

[JayPea00101010]

it's good now though

[ColdAnkles]

I make more mistakes attempting to fix something than I make breaking things in the first place. Will merge soon if nobody objects

[ColdAnkles]

I had a thought, make it subraces-dwarf.xml instead so it ends up grouped with other subrace files (if any)

[JayPea00101010]

Don't push it yet anyway, I think swd said ungrant was coming next version and as this is at the moment it requires a push to the main pull, since the next version is coming fairly soon it's probably better to wait until that's a thing

[JayPea00101010]

and I'll change the name when I change it with ungrant because I'm lazy so there's no more unnessesary commits

[ColdAnkles]

Created a label specifically for pulls that require updates to Aurora itself before they get merged.