-
Notifications
You must be signed in to change notification settings - Fork 320
Allow Detection of WWW Autolinks #406
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 1 commit
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
3208a83
Allow Detection of WWW Autolinks
rdestefa 675d2c4
Address PR Comments
rdestefa 4186529
Add Changelog Entry
rdestefa 64f76d9
Fix Changelog Typo
rdestefa e49094c
Address PR Comments 2
rdestefa 53bf47d
Fix Test Failure
rdestefa 889709c
Typo
rdestefa File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
16 changes: 16 additions & 0 deletions
16
commonmark-ext-autolink/src/main/java/org/commonmark/ext/autolink/AutolinkType.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,16 @@ | ||
| package org.commonmark.ext.autolink; | ||
|
|
||
| public enum AutolinkType { | ||
| /** | ||
| * URL such as {@code http://example.com} | ||
| */ | ||
| URL, | ||
| /** | ||
| * Email address such as {@code [email protected]} | ||
| */ | ||
| EMAIL, | ||
| /** | ||
| * URL such as {@code www.example.com} | ||
| */ | ||
| WWW | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No need to duplicate the checks above if we're delegating to
linkTypes(Set<AutolinkType> linkTypes)anyway.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Removed the second check. The first check was just to provide a more explicit error message than whatever is thrown by calling
Set.of(null), but I can remove if we think that's unnecessary.