fix: resolve install.ps1 latest version without the GitHub API#560
Open
hiyochi wants to merge 1 commit into
Open
fix: resolve install.ps1 latest version without the GitHub API#560hiyochi wants to merge 1 commit into
hiyochi wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
fixed
install.shto resolve the latest version via the web redirect instead of the GitHub API (rate-limited to 60 requests/hour per IP, returning 403 on shared hosts). The same fix was not applied toinstall.ps1, which still uses the API directly.Fix
Port the same three optimizations from #336 to
install.ps1:releases/latestweb redirect (github.com/<repo>/releases/latest→BaseResponse.ResponseUri→.../tag/vX.Y.Z) instead of the API — no token, no rate limit. Falls back to the API if the redirect can't be read.try/catchso a network failure on one path doesn't abort the installer before the fallback runs.Validation
pwsh -NoProfile -Command "& { Get-Content install.ps1 | Out-Null }"— syntax check passes.install.shpost-fix: resolve install.sh latest version without the GitHub API (#325) #336: redirect-first, API-fallback, version normalization.