coding-area-net · DomiIRL · Apr 18, 2025 · Apr 18, 2025
diff --git a/...codingarea/challenges/plugin/challenges/custom/settings/action/impl/HealEntityAction.java b/...codingarea/challenges/plugin/challenges/custom/settings/action/impl/HealEntityAction.java
@@ -2,13 +2,11 @@
 
 import net.codingarea.challenges.plugin.challenges.custom.settings.action.EntityTargetAction;
 import net.codingarea.challenges.plugin.challenges.type.helper.SubSettingsHelper;
-import net.codingarea.challenges.plugin.utils.bukkit.misc.version.MinecraftVersion;
 import net.codingarea.challenges.plugin.utils.bukkit.misc.wrapper.AttributeWrapper;
 import net.codingarea.challenges.plugin.utils.item.DefaultItem;
 import net.codingarea.challenges.plugin.utils.item.ItemBuilder;
 import net.codingarea.challenges.plugin.utils.misc.MinecraftNameWrapper;
 import org.bukkit.Material;
-import org.bukkit.attribute.Attribute;
 import org.bukkit.attribute.AttributeInstance;
 import org.bukkit.entity.Entity;
 import org.bukkit.entity.LivingEntity;

diff --git a/...a/net/codingarea/challenges/plugin/challenges/custom/settings/sub/SubSettingsBuilder.java b/...a/net/codingarea/challenges/plugin/challenges/custom/settings/sub/SubSettingsBuilder.java
@@ -1,5 +1,6 @@
 package net.codingarea.challenges.plugin.challenges.custom.settings.sub;
 
+import lombok.Getter;
 import net.anweisen.utilities.common.misc.StringUtils;
 import net.codingarea.challenges.plugin.challenges.custom.settings.sub.builder.*;
 import net.codingarea.challenges.plugin.content.Message;
@@ -15,6 +16,7 @@
 import java.util.function.Consumer;
 import java.util.function.Predicate;
 
+@Getter
 public abstract class SubSettingsBuilder {
 
 	private String key;
@@ -59,11 +61,7 @@ public static EmptySubSettingsBuilder createEmpty() {
 
 	public abstract boolean hasSettings();
 
-	public SubSettingsBuilder getParent() {
-		return parent;
-	}
-
-	public SubSettingsBuilder setParent(SubSettingsBuilder parent) {
+    public SubSettingsBuilder setParent(SubSettingsBuilder parent) {
 
 		SubSettingsBuilder parentBuilder = getParent();
 		if (parentBuilder != null) {
@@ -75,15 +73,7 @@ public SubSettingsBuilder setParent(SubSettingsBuilder parent) {
 
 	}
 
-	public SubSettingsBuilder getChild() {
-		return child;
-	}
-
-	public String getKey() {
-		return key;
-	}
-
-	public SubSettingsBuilder setKey(String key) {
+    public SubSettingsBuilder setKey(String key) {
 		this.key = key;
 		return this;
 	}

diff --git a/...t/codingarea/challenges/plugin/challenges/custom/settings/trigger/impl/HungerTrigger.java b/...t/codingarea/challenges/plugin/challenges/custom/settings/trigger/impl/HungerTrigger.java
@@ -21,7 +21,7 @@ public Material getMaterial() {
 	@EventHandler(priority = EventPriority.HIGH, ignoreCancelled = true)
 	public void onPickup(FoodLevelChangeEvent event) {
 		if (!(event.getEntity() instanceof Player)) return;
-		if (event.getFoodLevel() < ((Player) event.getEntity()).getFoodLevel()) {
+		if (event.getFoodLevel() < event.getEntity().getFoodLevel()) {
 			createData()
 					.entity(event.getEntity())
 					.event(event)

diff --git a/...allenges/plugin/challenges/custom/settings/trigger/impl/StandsOnSpecificBlockTrigger.java b/...allenges/plugin/challenges/custom/settings/trigger/impl/StandsOnSpecificBlockTrigger.java
@@ -9,6 +9,8 @@
 import org.bukkit.event.EventPriority;
 import org.bukkit.event.player.PlayerMoveEvent;
 
+import java.util.Objects;
+
 public class StandsOnSpecificBlockTrigger extends ChallengeTrigger {
 
 	public StandsOnSpecificBlockTrigger(String name) {
@@ -24,7 +26,7 @@ public Material getMaterial() {
 	public void onMove(PlayerMoveEvent event) {
 		if (BlockUtils.isSameBlockLocation(event.getTo(), event.getFrom())) return;
 		Block blockBelow = BlockUtils.getBlockBelow(
-				event.getTo());
+                Objects.requireNonNull(event.getTo()));
 		if (blockBelow == null) return;
 
 		createData()

diff --git a/...codingarea/challenges/plugin/challenges/implementation/challenge/ZeroHeartsChallenge.java b/...codingarea/challenges/plugin/challenges/implementation/challenge/ZeroHeartsChallenge.java
@@ -8,13 +8,11 @@
 import net.codingarea.challenges.plugin.content.Prefix;
 import net.codingarea.challenges.plugin.management.menu.MenuType;
 import net.codingarea.challenges.plugin.management.scheduler.task.ScheduledTask;
-import net.codingarea.challenges.plugin.utils.bukkit.misc.version.MinecraftVersion;
 import net.codingarea.challenges.plugin.utils.bukkit.misc.wrapper.AttributeWrapper;
 import net.codingarea.challenges.plugin.utils.item.ItemBuilder;
 import net.codingarea.challenges.plugin.utils.misc.NameHelper;
 import org.bukkit.Bukkit;
 import org.bukkit.Material;
-import org.bukkit.attribute.Attribute;
 import org.bukkit.attribute.AttributeInstance;
 import org.bukkit.boss.BarColor;
 import org.bukkit.entity.Player;

diff --git a/...ea/challenges/plugin/challenges/implementation/challenge/entities/BlockMobsChallenge.java b/...ea/challenges/plugin/challenges/implementation/challenge/entities/BlockMobsChallenge.java
@@ -22,6 +22,7 @@
 import org.jetbrains.annotations.NotNull;
 
 import java.util.Collection;
+import java.util.Objects;
 
 @Since("2.1.3")
 public class BlockMobsChallenge extends Setting {
@@ -45,7 +46,7 @@ public void onBlockBreak(BlockBreakEvent event) {
 		LivingEntity entity = (LivingEntity) event.getBlock().getWorld()
 				.spawnEntity(event.getBlock().getLocation().add(0.5, 0, 0.5), type);
 
-		Collection<ItemStack> drops = event.getBlock().getDrops(event.getPlayer().getEquipment().getItemInMainHand());
+		Collection<ItemStack> drops = event.getBlock().getDrops(Objects.requireNonNull(event.getPlayer().getEquipment()).getItemInMainHand());
 
 		int i = 0;
 		// Put every stack in a different slot to make sure everything drops properly
@@ -56,7 +57,8 @@ public void onBlockBreak(BlockBreakEvent event) {
 
 			switch (i) {
 				case 0:
-					equipment.setHelmetDropChance(1);
+                    assert equipment != null;
+                    equipment.setHelmetDropChance(1);
 					break;
 				case 1:
 					slot = EquipmentSlot.CHEST;

diff --git a/...hallenges/plugin/challenges/implementation/challenge/inventory/UncraftItemsChallenge.java b/...hallenges/plugin/challenges/implementation/challenge/inventory/UncraftItemsChallenge.java
@@ -17,6 +17,7 @@
 import javax.annotation.Nullable;
 import java.util.ArrayList;
 import java.util.List;
+import java.util.Objects;
 
 @Since("2.0.2")
 public class UncraftItemsChallenge extends TimedChallenge {
@@ -105,8 +106,8 @@ private static List<ItemStack> getIngredientsOfRecipe(@Nonnull Recipe recipe) {
 			ingredients.add(furnace.getInput());
 		} else if (MinecraftVersion.current().isNewerOrEqualThan(MinecraftVersion.V1_14) && recipe instanceof SmithingRecipe) {
 			SmithingRecipe smithing = (SmithingRecipe) recipe;
-			ingredients.add(smithing.getBase().getItemStack());
-			ingredients.add(smithing.getAddition().getItemStack());
+			ingredients.add(Objects.requireNonNull(smithing.getBase()).getItemStack());
+			ingredients.add(Objects.requireNonNull(smithing.getAddition()).getItemStack());
 		}
 
 		return ingredients;

diff --git a/...ugin/challenges/implementation/challenge/miscellaneous/NoSharedAdvancementsChallenge.java b/...ugin/challenges/implementation/challenge/miscellaneous/NoSharedAdvancementsChallenge.java
@@ -18,6 +18,7 @@
 
 import java.util.LinkedList;
 import java.util.List;
+import java.util.Objects;
 
 @Since("2.2.0")
 public class NoSharedAdvancementsChallenge extends Setting {
@@ -51,7 +52,7 @@ public void loadGameState(@NotNull Document document) {
 		List<String> advancementKeys = document.getStringList("advancements");
 		for (String advancementKey : advancementKeys) {
 			try {
-				advancementsDone.add(Bukkit.getAdvancement(BukkitReflectionUtils.fromString(advancementKey)));
+				advancementsDone.add(Bukkit.getAdvancement(Objects.requireNonNull(BukkitReflectionUtils.fromString(advancementKey))));
 			} catch (Exception exception) {
 				// DON'T EXIST
 			}

diff --git a/.../codingarea/challenges/plugin/challenges/implementation/challenge/quiz/QuizChallenge.java b/.../codingarea/challenges/plugin/challenges/implementation/challenge/quiz/QuizChallenge.java
@@ -15,14 +15,12 @@
 import net.codingarea.challenges.plugin.management.scheduler.task.ScheduledTask;
 import net.codingarea.challenges.plugin.spigot.events.PlayerJumpEvent;
 import net.codingarea.challenges.plugin.utils.bukkit.command.PlayerCommand;
-import net.codingarea.challenges.plugin.utils.bukkit.misc.version.MinecraftVersion;
 import net.codingarea.challenges.plugin.utils.bukkit.misc.wrapper.AttributeWrapper;
 import net.codingarea.challenges.plugin.utils.item.ItemBuilder;
 import net.codingarea.challenges.plugin.utils.misc.BlockUtils;
 import net.codingarea.challenges.plugin.utils.misc.NameHelper;
 import net.codingarea.challenges.plugin.utils.misc.TriFunction;
 import org.bukkit.Material;
-import org.bukkit.attribute.Attribute;
 import org.bukkit.attribute.AttributeInstance;
 import org.bukkit.boss.BarColor;
 import org.bukkit.command.Command;
@@ -565,8 +563,8 @@ public void onMove(@Nonnull PlayerDropItemEvent event) {
 	@EventHandler(priority = EventPriority.MONITOR, ignoreCancelled = true)
 	public void onMove(@Nonnull EntityDamageEvent event) {
 		if (!shouldExecuteEffect()) return;
-		if (!(event.getEntity() instanceof Player)) return;;
-		Player player = (Player) event.getEntity();
+		if (!(event.getEntity() instanceof Player)) return;
+        Player player = (Player) event.getEntity();
 		if (ignorePlayer(player)) return;
 		SavedStatistic.DAMAGE_TAKEN.increaseStatistic(player, event.getCause().name(), ChallengeHelper.getFinalDamage(event));
 	}

diff --git a/...hallenges/plugin/challenges/implementation/challenge/randomizer/RandomEventChallenge.java b/...hallenges/plugin/challenges/implementation/challenge/randomizer/RandomEventChallenge.java
@@ -34,10 +34,10 @@ public RandomEventChallenge() {
 		setCategory(SettingCategory.RANDOMIZER);
 		events = new Event[]{
 				new SpeedEvent(),
-				new SpawnEntitiesEvent(),
+                new SpawnEntitiesEvent(),
 				new HoleEvent(),
 				new FlyEvent(),
-				new CobWebEvent(),
+                new CobWebEvent(),
 				new ReplaceOresEvent(),
 				new SicknessEvent()
 		};
@@ -186,7 +186,7 @@ public void run(@Nonnull Player player) {
 		}
 	}
 
-	public class SpawnEntitiesEvent implements Event {
+	public static class SpawnEntitiesEvent implements Event {
 
 		@Nonnull
 		@Override
@@ -210,7 +210,7 @@ public void run(@Nonnull Player player) {
 
 	}
 
-	public class CobWebEvent implements Event {
+	public static class CobWebEvent implements Event {
 
 		@Nonnull
 		@Override

diff --git a/...es/plugin/challenges/implementation/challenge/randomizer/RandomItemDroppingChallenge.java b/...es/plugin/challenges/implementation/challenge/randomizer/RandomItemDroppingChallenge.java
@@ -27,7 +27,7 @@ public RandomItemDroppingChallenge() {
 	}
 
 	public static void dropRandomItem(Player player) {
-		if (player.getInventory().getContents().length <= 0) return;
+		if (player.getInventory().getContents().length == 0) return;
 		dropRandomItem(player.getLocation(), player.getInventory());
 	}
 

diff --git a/...es/plugin/challenges/implementation/challenge/randomizer/RandomItemRemovingChallenge.java b/...es/plugin/challenges/implementation/challenge/randomizer/RandomItemRemovingChallenge.java
@@ -51,7 +51,7 @@ protected void onTimeActivation() {
 
 		for (Player player : Bukkit.getOnlinePlayers()) {
 			if (ignorePlayer(player)) continue;
-			if (player.getInventory().getContents().length <= 0) continue;
+			if (player.getInventory().getContents().length == 0) continue;
 
 			Bukkit.getScheduler().runTask(plugin, () -> {
 				InventoryUtils.removeRandomItem(player.getInventory());

diff --git a/...es/plugin/challenges/implementation/challenge/randomizer/RandomItemSwappingChallenge.java b/...es/plugin/challenges/implementation/challenge/randomizer/RandomItemSwappingChallenge.java
@@ -26,7 +26,7 @@ public RandomItemSwappingChallenge() {
 	}
 
 	public static void swapRandomItems(Player player) {
-		if (player.getInventory().getContents().length <= 0) return;
+		if (player.getInventory().getContents().length == 0) return;
 		int slot = InventoryUtils.getRandomFullSlot(player.getInventory());
 		if (slot == -1) return;
 		swapItemToRandomSlot(

diff --git a/...allenges/plugin/challenges/implementation/challenge/randomizer/RandomizedHPChallenge.java b/...allenges/plugin/challenges/implementation/challenge/randomizer/RandomizedHPChallenge.java
@@ -6,7 +6,6 @@
 import net.codingarea.challenges.plugin.content.Message;
 import net.codingarea.challenges.plugin.management.menu.MenuType;
 import net.codingarea.challenges.plugin.management.menu.generator.categorised.SettingCategory;
-import net.codingarea.challenges.plugin.utils.bukkit.misc.version.MinecraftVersion;
 import net.codingarea.challenges.plugin.utils.bukkit.misc.wrapper.AttributeWrapper;
 import net.codingarea.challenges.plugin.utils.item.ItemBuilder;
 import net.codingarea.challenges.plugin.utils.item.ItemBuilder.PotionBuilder;
@@ -15,7 +14,6 @@
 import org.bukkit.Material;
 import org.bukkit.World;
 import org.bukkit.World.Environment;
-import org.bukkit.attribute.Attribute;
 import org.bukkit.attribute.AttributeInstance;
 import org.bukkit.entity.Entity;
 import org.bukkit.entity.EntityType;

diff --git a/...codingarea/challenges/plugin/challenges/implementation/challenge/world/LoopChallenge.java b/...codingarea/challenges/plugin/challenges/implementation/challenge/world/LoopChallenge.java
@@ -13,7 +13,6 @@
 import net.codingarea.challenges.plugin.management.scheduler.task.ScheduledTask;
 import net.codingarea.challenges.plugin.management.scheduler.task.TimerTask;
 import net.codingarea.challenges.plugin.management.scheduler.timer.TimerStatus;
-import net.codingarea.challenges.plugin.utils.bukkit.misc.version.MinecraftVersion;
 import net.codingarea.challenges.plugin.utils.bukkit.misc.wrapper.AttributeWrapper;
 import net.codingarea.challenges.plugin.utils.item.ItemBuilder;
 import net.codingarea.challenges.plugin.utils.misc.InventoryUtils;
@@ -186,13 +185,11 @@ public void execute() {
 	private static class EntityDamageLoop implements Loop {
 
 		private final LivingEntity entity;
-		private final DamageCause damageCause;
-		private final double damage;
+        private final double damage;
 
 		public EntityDamageLoop(LivingEntity entity, DamageCause cause, double damage) {
 			this.entity = entity;
-			this.damageCause = cause;
-			this.damage = damage;
+            this.damage = damage;
 		}
 
 		@Override
@@ -301,7 +298,7 @@ private boolean decreaseDurability() {
 			org.bukkit.inventory.meta.Damageable damageable = (org.bukkit.inventory.meta.Damageable) itemStack.getItemMeta();
 			if (damageable == null) return false;
 			damageable.setDamage(damageable.getDamage() + 1);
-			itemStack.setItemMeta((ItemMeta) damageable);
+			itemStack.setItemMeta(damageable);
 
 			for (int slot = 0; slot < player.getInventory().getSize(); slot++) {
 				ItemStack item = player.getInventory().getItem(slot);

diff --git a/...odingarea/challenges/plugin/challenges/implementation/challenge/world/SnakeChallenge.java b/...odingarea/challenges/plugin/challenges/implementation/challenge/world/SnakeChallenge.java
@@ -39,12 +39,7 @@ public ItemBuilder createDisplayItem() {
 		return new ItemBuilder(Material.BLUE_TERRACOTTA, Message.forName("item-snake-challenge"));
 	}
 
-	@Override
-	protected void onEnable() {
-
-	}
-
-	@Override
+    @Override
 	protected void onDisable() {
 		blocks.clear();
 	}

diff --git a/.../net/codingarea/challenges/plugin/challenges/implementation/goal/CollectAllItemsGoal.java b/.../net/codingarea/challenges/plugin/challenges/implementation/goal/CollectAllItemsGoal.java
@@ -1,5 +1,6 @@
 package net.codingarea.challenges.plugin.challenges.implementation.goal;
 
+import lombok.Getter;
 import net.anweisen.utilities.bukkit.utils.animation.SoundSample;
 import net.codingarea.challenges.plugin.utils.item.ItemUtils;
 import net.anweisen.utilities.common.annotations.Since;
@@ -36,11 +37,15 @@
 @Since("2.0")
 public class CollectAllItemsGoal extends SettingGoal implements SenderCommand {
 
-	private final int totalItemsCount;
+	@Getter
+    private final int totalItemsCount;
 	private SeededRandomWrapper random;
-	private List<Material> allItemsToFind;
-	private List<Material> itemsToFind;
-	private Material currentItem;
+	@Getter
+    private List<Material> allItemsToFind;
+	@Getter
+    private List<Material> itemsToFind;
+	@Getter
+    private Material currentItem;
 
 	public CollectAllItemsGoal() {
 		random = new SeededRandomWrapper();
@@ -168,23 +173,7 @@ public void writeGameState(@Nonnull Document document) {
 		document.set("found", totalItemsCount - itemsToFind.size());
 	}
 
-	public Material getCurrentItem() {
-		return currentItem;
-	}
-
-	public List<Material> getItemsToFind() {
-		return itemsToFind;
-	}
-
-	public List<Material> getAllItemsToFind() {
-		return allItemsToFind;
-	}
-
-	public int getTotalItemsCount() {
-		return totalItemsCount;
-	}
-
-	private String getItemDisplayName(@Nullable Material material) {
+    private String getItemDisplayName(@Nullable Material material) {
 		if (material == null) return "Unbekannt";
 
 		String name = material.name();

diff --git a/...va/net/codingarea/challenges/plugin/challenges/implementation/goal/GetFullHealthGoal.java b/...va/net/codingarea/challenges/plugin/challenges/implementation/goal/GetFullHealthGoal.java
@@ -8,12 +8,10 @@
 import net.codingarea.challenges.plugin.management.menu.MenuType;
 import net.codingarea.challenges.plugin.management.menu.generator.categorised.SettingCategory;
 import net.codingarea.challenges.plugin.management.server.ChallengeEndCause;
-import net.codingarea.challenges.plugin.utils.bukkit.misc.version.MinecraftVersion;
 import net.codingarea.challenges.plugin.utils.bukkit.misc.wrapper.AttributeWrapper;
 import net.codingarea.challenges.plugin.utils.item.ItemBuilder;
 import org.bukkit.Bukkit;
 import org.bukkit.Material;
-import org.bukkit.attribute.Attribute;
 import org.bukkit.attribute.AttributeInstance;
 import org.bukkit.entity.Player;
 import org.bukkit.event.EventHandler;

diff --git a/...a/net/codingarea/challenges/plugin/challenges/implementation/goal/KillAllMonsterGoal.java b/...a/net/codingarea/challenges/plugin/challenges/implementation/goal/KillAllMonsterGoal.java
@@ -26,7 +26,10 @@ public KillAllMonsterGoal() {
 	static List<EntityType> getAllMobsToKill() {
 		LinkedList<EntityType> list = new LinkedList<>(Arrays.asList(EntityType.values()));
 		list.removeIf(type -> !type.isAlive());
-		list.removeIf(type -> !Monster.class.isAssignableFrom(type.getEntityClass()));
+		list.removeIf(type -> {
+            assert type.getEntityClass() != null;
+            return !Monster.class.isAssignableFrom(type.getEntityClass());
+        });
 		list.add(EntityType.PHANTOM);
 		list.add(EntityType.ENDER_DRAGON);
 		list.add(EntityType.SHULKER);