fix(inline-tools): inline tools shortcuts now works in read-only mode#2891
Merged
Conversation
VolgaIgor
pushed a commit
to VolgaIgor/editor.js
that referenced
this pull request
Nov 11, 2025
…codex-team#2891) * fix(inline-tools): inline tools shortcuts now works in read-only mode * use ubuntu-20.04 instead of latest
ldeaudit1
reviewed
May 6, 2026
Comment on lines
+552
to
+555
| /** | ||
| * We need to bind shortcut to the document to make it work in read-only mode | ||
| */ | ||
| on: document, |
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
Member
Author
There was a problem hiding this comment.
Thanks for the feedback. Please, create an issue for that.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Inline Tools (with
isReadOnlySupported=true) shortcuts does not work in the Read-Only modeCause
Their shortcut was bound to
Ui.nodes.redactor, but in Read-Only mode this element is not focused, since there is no focus at all.Solution
Now we bind Inline Tools shortcuts to the document