Skip to content

Issue 143 allow playable game width and height to be null#144

Open
laurenpudz wants to merge 3 commits intomainfrom
issue-143-allow_playable_game_width_and_height_to_be_null
Open

Issue 143 allow playable game width and height to be null#144
laurenpudz wants to merge 3 commits intomainfrom
issue-143-allow_playable_game_width_and_height_to_be_null

Conversation

@laurenpudz
Copy link
Contributor

@laurenpudz laurenpudz commented Feb 28, 2026

Change Summary

[Briefly summarise the changes that you made. Just high-level stuff]

Change Form

Fill this up (NA if not available). If a certain criteria is not met, can you please give a reason.

  • The pull request title has an issue number
  • The change works by "Smoke testing" or quick testing
  • The change has tests
  • The change has documentation

Other Information

[Is there anything in particular in the review that I should be aware of?]

  • allowed null/blank for game embed height and width
  • added validation on the model that if the playable game ID is not null then both the game width and height must be non null
  • refactored gameEmbedID to gamePlayableID on the frontend to match the field name used on the backend (was producing an undefined gameEmbedID value before that was breaking stuff)
  • changed logic to check when game embed should now render. Will now only render when gamePlayableID, gameWidth and gameHeight are truthy (so filter out if any are null/undefined, 0, False etc...)
image ^ validation on admin site (if height is filled out but width is left blank, the width box will show an error the same way)

Related issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

allow playable game width and height to be null

1 participant