Skip to content

fix: remove cached execute for run marker command #18

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mafredri merged 1 commit into from
Jul 17, 2024
Merged

fix: remove cached execute for run marker command #18

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 0 additions & 6 deletions pkg/commands/run_marker.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,12 +47,6 @@ func (r *RunMarkerCommand) ExecuteCommand(config *v1.Config, buildArgs *dockerfi
return nil
}

func (r *RunMarkerCommand) CachedExecuteCommand(config *v1.Config, buildArgs *dockerfile.BuildArgs) error {
// TODO(mafredri): Check if we need to do more here.
r.Files = []string{}
return nil
}

// String returns some information about the command for the image config
func (r *RunMarkerCommand) String() string {
return r.cmd.String()
Expand Down
3 changes: 3 additions & 0 deletions pkg/executor/build.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -509,6 +509,9 @@ func (s *stageBuilder) probeCache() error {
case *commands.RunCommand:
// If the cache is valid, we expect CachingRunCommand.
return errors.Errorf("uncached RUN command is not supported in cache probe mode")
case *commands.RunMarkerCommand:
// If the cache is valid, we expect CachingRunCommand.
return errors.Errorf("uncached RUN command is not supported in cache probe mode")
default:
return errors.Errorf("unsupported command %T encountered in cache probe mode, missing CachedExecuteCommand", command)
}
Expand Down