You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This PR is a breaking change!
It renames a publicly accessible CLI option referenced in #184.
It should not be merged into release/1.0 as this would break at least the terraform provider that relies on this option.
This commit may be cherry-picked into release/2.0 when that branch is created.
@mafredri Are you happy with us merging this to main now? Or would you like to defer this to a later date so we don't end up needing to do too many backport changes?
@mafredri Are you happy with us merging this to main now? Or would you like to defer this to a later date so we don't end up needing to do too many backport changes?
(We could just make it backwards compatible for a period of time by including the old property (and checking it too) but marking it deprecated. That way we’re not in a rush to sync the changes to the provider.)
I’m also fine with merging as-is, but I’d avoid cherry-picking it into release/1.0 unless there are conflicts. Our next non-patch release should be release/1.1, which we branch out from main, and I think it’s fine to include this there.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is a breaking change!
It renames a publicly accessible CLI option referenced in #184.
It should not be merged into release/1.0 as this would break at least the terraform provider that relies on this option.
This commit may be cherry-picked into release/2.0 when that branch is created.
This PR closes #184.