fix(devcontainer): correctly parse feature with digest#248
Merged
johnstcn merged 1 commit intocoder:mainfrom Jun 25, 2024
Merged
fix(devcontainer): correctly parse feature with digest#248johnstcn merged 1 commit intocoder:mainfrom
johnstcn merged 1 commit intocoder:mainfrom
Conversation
651d803 to
d987f0b
Compare
johnstcn
approved these changes
Jun 25, 2024
Member
johnstcn
left a comment
There was a problem hiding this comment.
Thanks for the contribution! name.ParseReference uses NewTag under the hood (falling back to NewDigest), so this looks fine to me. 👍
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello! 👋
Parsing an image with a digest like
ghcr.io/coder/envbuilder:0.2.9@sha256:b51153d8cc1235986707d5f61949884444f2b4c4f64b15b5506cb5484bfa8a93usingNewTagdoes not work:ParseReferencesupports both tag and digest, and produces the same result.