chore: make sure directives are correct#235
Closed
BrunoQuaresma wants to merge 3 commits intomainfrom
Closed
Conversation
johnstcn
reviewed
Jun 13, 2024
Member
johnstcn
left a comment
There was a problem hiding this comment.
I verified the behaviour is correct 👍
Do we need to modify these directives if we are not pushing the image?
Contributor
Author
johnstcn
reviewed
Jun 13, 2024
Comment on lines
+1394
to
+1396
| require.Equal(t, configFile.Config.User, "root", "value does not match any of the possible root user values.") | ||
| require.Equal(t, configFile.Config.WorkingDir, "/", "expected image to have root working directory") | ||
| require.Equal(t, configFile.Config.Entrypoint, []string{"/.envbuilder/bin/envbuilder"}, "expected image to have envbuilder entrypoint") |
Member
There was a problem hiding this comment.
probably a good idea to assert the opposite in some other test when we don't push
Contributor
Author
There was a problem hiding this comment.
If they are not pushed, what reference can we use to get the local image and inspect it?
mtojek
reviewed
Jun 14, 2024
|
|
||
| if options.PushImage { | ||
| // Make sure the Dockerfile is using the correct directives to run envbuilder | ||
| buildParams.DockerfileContent = buildParams.DockerfileContent + "\n" + |
Member
There was a problem hiding this comment.
I guess that you'll have a merge conflict with the other PR: #216
Contributor
Author
|
This is blocked by #216 because it needs to have the embed binary to set the entrypoint correctly |
Member
|
closing in favour of #246 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #217