Remove envbuilder dependency from devcontainer_test#115
Merged
aaronlehmann merged 2 commits intocoder:mainfrom Mar 27, 2024
Merged
Remove envbuilder dependency from devcontainer_test#115aaronlehmann merged 2 commits intocoder:mainfrom
aaronlehmann merged 2 commits intocoder:mainfrom
Conversation
devcontainer_test imports the top-level envbuilder package, which creates a transitive dependency on kaniko for external code that imports envbuilder/devcontainer. Moving the test file to the top level avoids this dependency.
kylecarbs
requested changes
Mar 27, 2024
Member
kylecarbs
left a comment
There was a problem hiding this comment.
Since we only use envbuilder.MagicDir in this file, I'd prefer to copy/paste that var into the test file as a const.
I think it's less idiomatic to split the test from the package rather than duplicate some code.
kylecarbs
approved these changes
Mar 27, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
devcontainer_testimports the top-level envbuilder package, which creates a transitive dependency on kaniko for external code that importsenvbuilder/devcontainer. Duplicatingenvbuilder.MagicDirwithin the test allows us to remove this dependency.