Skip to content

Conversation

@code-asher
Copy link
Member

Fixes #5378

@code-asher code-asher requested a review from a team August 12, 2022 17:25
@code-asher code-asher force-pushed the fix-socket-disconnect branch from 69b4387 to 1bd9d14 Compare August 12, 2022 17:27
@codecov
Copy link

codecov bot commented Aug 12, 2022

Codecov Report

Merging #5451 (1bd9d14) into main (b091b00) will not change coverage.
The diff coverage is n/a.

❗ Current head 1bd9d14 differs from pull request most recent head 7fb0028. Consider uploading reports for the commit 7fb0028 to get more accurate results

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #5451   +/-   ##
=======================================
  Coverage   72.44%   72.44%           
=======================================
  Files          30       30           
  Lines        1673     1673           
  Branches      366      366           
=======================================
  Hits         1212     1212           
  Misses        398      398           
  Partials       63       63           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b091b00...7fb0028. Read the comment docs.

Copy link
Contributor

@jsjoeio jsjoeio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very happy to see a fix for this. This seems like one that should be submitted upstream potentially.

@code-asher
Copy link
Member Author

This seems like one that should be submitted upstream potentially.

Definitely agree.

@code-asher code-asher enabled auto-merge (squash) August 15, 2022 17:58
@code-asher code-asher force-pushed the fix-socket-disconnect branch from 1bd9d14 to 7fb0028 Compare August 15, 2022 17:58
@code-asher code-asher merged commit 43b87ed into coder:main Aug 15, 2022
@code-asher code-asher deleted the fix-socket-disconnect branch August 15, 2022 18:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: intermittent reconnection

2 participants