Skip to content

Make assets unique #518

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
kylecarbs merged 2 commits into from
Apr 17, 2019
Merged

Make assets unique #518

kylecarbs merged 2 commits into from
Apr 17, 2019

Conversation

@code-asher
Copy link
Member

@code-asher code-asher commented Apr 17, 2019 •
edited
Loading

  • Make all CSS and JavaScript assets uniquely named.
  • Move the login page to /login.
  • Manually include all desired assets. This prevents caching / and /login itself which made it so you had to refresh or log in twice in some cases.

@code-asher code-asher changed the title Fix/unique assets Make assets unique Apr 17, 2019
@code-asher code-asher marked this pull request as ready for review April 17, 2019 20:38
@code-asher code-asher requested a review from kylecarbs as a code owner April 17, 2019 20:38
@code-asher
Make all assets unique
ee31f12 
All CSS and JavaScript files have unique names now. I also moved the
login to the /login path in order to ensure the HTML for each page is
also unique.
@kylecarbs
Copy link
Member

kylecarbs commented Apr 17, 2019

Pretty neat. I like it 🎊

lucacasonato
lucacasonato suggested changes Apr 17, 2019
View reviewed changes
@kylecarbs kylecarbs merged commit cc8c7e2 into master Apr 17, 2019
@kylecarbs kylecarbs deleted the fix/unique-assets branch April 17, 2019 22:18
code-asher added a commit that referenced this pull request Jun 19, 2019
@code-asher @kylecarbs
Make assets unique (#518)
55d4de0 
* Make all assets unique

All CSS and JavaScript files have unique names now. I also moved the
login to the /login path in order to ensure the HTML for each page is
also unique.

* Explicitly include assets to cache
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kylecarbs kylecarbs kylecarbs approved these changes

+1 more reviewer

@lucacasonato lucacasonato lucacasonato requested changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@code-asher @kylecarbs @lucacasonato