Skip to content

Update dependencies in package.json #1905

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
nhooyr wants to merge 1 commit into from
Closed

Update dependencies in package.json #1905

nhooyr wants to merge 1 commit into from

Conversation

@nhooyr
Copy link
Contributor

@nhooyr nhooyr commented Jul 22, 2020

Updates #1898

@nhooyr nhooyr requested a review from code-asher July 22, 2020 22:43
code-asher
code-asher approved these changes Aug 17, 2020
View reviewed changes
Copy link
Member

@code-asher code-asher left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, my only question is whether we need to add the safe-buffer dep?

@nhooyr
Copy link
Contributor Author

nhooyr commented Aug 17, 2020

Yea not sure what happened there, will retry updating.

@nhooyr
Copy link
Contributor Author

nhooyr commented Aug 25, 2020

So yea we do actually.

@nhooyr nhooyr changed the base branch from master to dev August 25, 2020 18:48
@nhooyr nhooyr closed this Aug 25, 2020
@nhooyr nhooyr mentioned this pull request Aug 25, 2020
Merged
nhooyr added a commit that referenced this pull request Aug 26, 2020
@nhooyr
Update dependencies in package.json
c80d093 
See #1898 and #1905
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@code-asher code-asher code-asher approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@nhooyr @code-asher