Skip to content
This repository was archived by the owner on May 9, 2020. It is now read-only.

Update reCaptcha handling - #260

Merged
codemanki merged 7 commits into
masterfrom
unknown repository
Sep 24, 2019
Merged

Update reCaptcha handling#260
codemanki merged 7 commits into
masterfrom
unknown repository

Conversation

@ghost

@ghost ghost commented Sep 14, 2019

Copy link
Copy Markdown

Fixes #259

@ghost
ghost requested a review from codemanki September 14, 2019 05:29
@codemanki

Copy link
Copy Markdown
Owner

Thank you!

@codemanki

Copy link
Copy Markdown
Owner

I guess this should be a minor version bump?

@ghost

ghost commented Sep 19, 2019

Copy link
Copy Markdown
Author

Please allow me to review it again as something just caught my eye.
Minor version bump.

One sec...

@codemanki

Copy link
Copy Markdown
Owner

No problem, take your time

Comment thread index.js Outdated
@ghost

ghost commented Sep 19, 2019

Copy link
Copy Markdown
Author

For quick testing:

const cloudscraper = require('.');
cloudscraper.debug = true;
cloudscraper.get({ uri: 'https://captcha.website', onCaptcha: () => {} })

// Logs response.captcha, siteKey matches, and whether a fallback was used.

It won't log all of the siteKey matches unless debugging and the primary isn't found.
In practice, all of the keys are the same but it's defensive anyway and prefers the best possible match.

@ghost ghost added the concluded Ready for review label Sep 19, 2019
@codemanki
codemanki merged commit 56e79eb into codemanki:master Sep 24, 2019
@ghost
ghost deleted the recaptcha branch September 24, 2019 08:44
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Post request fails after initial cloudflare bypass.

1 participant