fix: expand tilde (~) in project_path to prevent silent failures#153
Merged
Conversation
Paths like "~/workspace/project" were not expanded, causing Path("~/...")
to interpret ~ as a literal directory name. This led to empty analysis
results and spurious ./~/ directories.
Changes:
- core.py: normalize project_path with expanduser().resolve() and
validate directory exists before dispatching to backends
- codeanalyzer.py: defensive expansion in PyCodeanalyzer for direct
instantiation, plus same treatment for cache_dir/analysis_json_path
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
"~/workspace/project"were not expanded, causingPath("~/...")to interpret~as a literal directory name./~/directories being createdChanges
core.py: normalizeproject_pathwithexpanduser().resolve()and validate directory exists before dispatching to backendscodeanalyzer.py: defensive expansion inPyCodeanalyzerfor direct instantiation, plus same treatment forcache_dir/analysis_json_pathTest plan
CldkInitializationExceptionwith clear message