fix: Limit news posts grabbed from the forums and fix deployment.#402
Merged
fix: Limit news posts grabbed from the forums and fix deployment.#402
Conversation
Collaborator
Author
|
Seeing all of the failures - looks like we need remove older PHP versions from our scripts since we are serving on 8.1, we don't care if they pass on previous versions. Personally, I think we can ignore these errors and get this fix out and fix that in a separate PR. |
kenjis
approved these changes
Sep 29, 2023
Contributor
kenjis
left a comment
There was a problem hiding this comment.
Okay.
$ composer test
> phpunit
PHPUnit 9.6.13 by Sebastian Bergmann and contributors.
Runtime: PHP 8.1.23
Configuration: /Users/kenji/work/codeigniter/official/ci4-website/phpunit.xml
Random Seed: 1695960489
................................... 35 / 35 (100%)
Nexus\PHPUnit\Extension\Tachycardia identified these 5 slow tests:
+--------------------------------------------------+---------------+-------------+
| Test Case | Time Consumed | Time Limit |
+--------------------------------------------------+---------------+-------------+
| BasicPagesTest::testCanViewContribute | 00:00:02.86 | 00:00:00.50 |
| BasicPagesTest::testCanViewHome | 00:00:02.68 | 00:00:00.50 |
| BasicPagesTest::testCanViewDownload | 00:00:01.27 | 00:00:00.50 |
| App\\Entities\\GitHub\\GitHubTest::testResolving | 00:00:01.02 | 00:00:00.50 |
| BlogLibraryTest::testGetPostSuccess | 00:00:00.59 | 00:00:00.50 |
+--------------------------------------------------+---------------+-------------+
Time: 00:10.047, Memory: 20.00 MB
OK (35 tests, 79 assertions)
Merged
Contributor
I sent PR #404 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.