Skip to content

Update to CI v4.3.5#371

Merged
kenjis merged 8 commits intocodeigniter4projects:developfrom
kenjis:update-to-ci435
Jun 4, 2023
Merged

Update to CI v4.3.5#371
kenjis merged 8 commits intocodeigniter4projects:developfrom
kenjis:update-to-ci435

Conversation

@kenjis
Copy link
Copy Markdown
Contributor

@kenjis kenjis commented May 24, 2023

Supersedes #370

  • update CI to v4.3.5
  • update project files
  • composer update
  • add tatter/patch

kenjis added 6 commits May 24, 2023 10:00
Upgrading codeigniter4/framework (v4.2.11 => v4.3.5)

 Conflicts:
	Views/welcome_message.php
	app/Config/App.php
	app/Config/Autoload.php
	app/Config/Paths.php
	app/Config/Session.php
	app/Controllers/BaseController.php
A mistake in merging.
Kint is loaded by the CodeIgniter class.
@coveralls
Copy link
Copy Markdown

coveralls commented May 24, 2023

Pull Request Test Coverage Report for Build 5063788887

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 73.86%

Totals Coverage Status
Change from base Build 4741691453: 0.0%
Covered Lines: 243
Relevant Lines: 329

💛 - Coveralls

@kenjis kenjis force-pushed the update-to-ci435 branch 4 times, most recently from ff3cd86 to e170112 Compare May 24, 2023 02:04
@kenjis kenjis force-pushed the update-to-ci435 branch from e170112 to 45c7bda Compare May 24, 2023 02:11
@kenjis
Copy link
Copy Markdown
Contributor Author

kenjis commented May 24, 2023

All checks have passed.

I don't know why but psalm-baseline.xml does not work.
In my local environment (macOS), psalm did not create psalm-baseline.xml but reported no error. But on GHA, psalm reported "Error while reading baseline: psalm-baseline.xml does not exist or is not readable". So I created it manually. But nothing changed.

Therefore I use @psalm-suppress instead of psalm-baseline.xml.

@kenjis kenjis merged commit 7e4bb3c into codeigniter4projects:develop Jun 4, 2023
@kenjis kenjis deleted the update-to-ci435 branch June 4, 2023 12:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants