[Rector] Apply StringifyStrNeedlesRector#891
Merged
samsonasik merged 4 commits intocodeigniter4:developfrom Oct 10, 2023
Merged
[Rector] Apply StringifyStrNeedlesRector#891samsonasik merged 4 commits intocodeigniter4:developfrom
samsonasik merged 4 commits intocodeigniter4:developfrom
Conversation
samsonasik
commented
Oct 10, 2023
Comment on lines
+38
to
+39
| /** @var string $searchHash */ | ||
| $searchHash = substr($hashedPword, 5); |
Member
Author
There was a problem hiding this comment.
on php 7.4, substr() can return false, that's why it uses @var here so phpstan now that it always return string
Member
Author
|
Ready to merge 👍 |
Member
Author
|
@kenjis thank you for the review, let's merge 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Enable
StringifyStrNeedlesRectorwith set@return array<int, string>tostrip_explode()method and run Rector to applyArraySpreadInsteadOfArrayMergeRectoras same type.Checklist: