Skip to content

chore: add phpstan-strict-rules#836

Merged
kenjis merged 4 commits intocodeigniter4:developfrom
kenjis:add-phpstan-strict-rules
Sep 15, 2023
Merged

chore: add phpstan-strict-rules#836
kenjis merged 4 commits intocodeigniter4:developfrom
kenjis:add-phpstan-strict-rules

Conversation

@kenjis
Copy link
Copy Markdown
Member

@kenjis kenjis commented Sep 15, 2023 •
edited
Loading

Description

  • add phpstan-strict-rules
  • enable rules
    • disallowedLooseComparison: true
    • booleansInConditions: true
    • disallowedConstructs: true
    • matchingInheritedMethodNames: true
  • update baseline

Ref codeigniter4/CodeIgniter4#7916

Checklist:

  • Securely signed commits
  • [] Component(s) with PHPDoc blocks, only if necessary or adds value
  • [] Unit testing, with >80% coverage
  • [] User guide updated
  • [] Conforms to style guide

@kenjis kenjis merged commit df8c1d4 into codeigniter4:develop Sep 15, 2023
@kenjis kenjis deleted the add-phpstan-strict-rules branch September 15, 2023 04:36
@datamweb datamweb mentioned this pull request Sep 15, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@datamweb datamweb datamweb approved these changes

@paulbalandan paulbalandan paulbalandan approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@kenjis @datamweb @paulbalandan