fix: Magic Link Login can be used even if $allowMagicLinkLogins is false

[datamweb]

fixed: #777

[datamweb]

[kenjis]

Re-ran failed jobs.

[kenjis]

We have three action methods.

$ php spark routes | grep MagicLinkController
| GET    | login/magic-link        | magic-link         | \CodeIgniter\Shield\Controllers\MagicLinkController::loginView     |                | toolbar       |
| GET    | login/verify-magic-link | verify-magic-link  | \CodeIgniter\Shield\Controllers\MagicLinkController::verify        |                | toolbar       |
| POST   | login/magic-link        | »                  | \CodeIgniter\Shield\Controllers\MagicLinkController::loginAction   |                | toolbar       |

Can you add the if statement to verify() just in case?

[datamweb]

Can you add the if statement to verify() just in case?

Honestly, I thought about this, isn't it better to have a private function?

    private function checkAllowMagicLink( ): RedirectResponse
   { 
        // Check if magic-link is not allowed
        if (!setting('Auth.allowMagicLinkLogins')) {
            return redirect()->route('login')->with('error', lang('Auth.magicLinkDisabled'));
        }
   }

[kenjis]

The three if statements are the exactly the same and the same meaning.
So it is better not to repeat them.

[kenjis]

RedirectResponse must be returned from this method if allowMagicLinkLogins is false.

[datamweb]

@kenjis, method verify(): RedirectResponse uses native return type , using a private method causes breaking change. Is it worth it?
Or am I missing something?

[kenjis]

using a private method causes breaking change.

No, it is not a breaking change.

But this PR works, so I merge for now.