Skip to content

docs: improve descriptions on permissions#714

Merged
kenjis merged 4 commits intocodeigniter4:developfrom
kenjis:docs-permissions
Apr 26, 2023
Merged

docs: improve descriptions on permissions#714
kenjis merged 4 commits intocodeigniter4:developfrom
kenjis:docs-permissions

Conversation

@kenjis
Copy link
Copy Markdown
Member

@kenjis kenjis commented Apr 26, 2023

See https://forum.codeigniter.com/showthread.php?tid=87457

  • add description for user-level and group-level permissions
  • update the comments in Config\AuthGroups.

@kenjis kenjis added the documentation Improvements or additions to documentation label Apr 26, 2023
@kenjis kenjis force-pushed the docs-permissions branch from 30d5dee to 6d5965d Compare April 26, 2023 07:02
Copy link
Copy Markdown
Collaborator

@datamweb datamweb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, I think change will help the following:

/**
* --------------------------------------------------------------------
* Permissions Matrix
* --------------------------------------------------------------------
* Maps permissions to groups.
*/

@kenjis
Copy link
Copy Markdown
Member Author

kenjis commented Apr 26, 2023

Updated the comments in Config\AuthGroups.

@kenjis kenjis requested a review from datamweb April 26, 2023 07:35
Copy link
Copy Markdown
Collaborator

@datamweb datamweb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 👍

@kenjis kenjis merged commit 94bbfe2 into codeigniter4:develop Apr 26, 2023
@kenjis kenjis deleted the docs-permissions branch April 26, 2023 07:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants