Merged
Conversation
datamweb
reviewed
Mar 22, 2023
Collaborator
datamweb
left a comment
There was a problem hiding this comment.
Thanks for the PR, however I'm not sure I'm the person who should approved, maybe MGatner or lonnieezell would be better to see here. I have not experienced this.
Co-authored-by: Pooya Parsa Dadashi <pooya_parsa_dadashi@yahoo.com>
Member
Author
|
Added notes to items that require administrator privileges. |
MGatner
approved these changes
Apr 5, 2023
| * Title: "Prep for 1.x.x release" | ||
| * Description: "Updates version references for `1.x.x`." (plus checklist) | ||
| * Let all tests run, then review and merge the PR | ||
| * Create a new PR from `develop` to `master`: |
Member
There was a problem hiding this comment.
I wouldn't normally go through all this trouble for a package. Not opposed, but it makes the release harder.
Member
Author
There was a problem hiding this comment.
Do you mean that not creating a PR but just run git merge?
When releasing a package, I normally just tag in a version branch like 1.x.
lonnieezell
approved these changes
Apr 5, 2023
Member
lonnieezell
left a comment
There was a problem hiding this comment.
Looks great. Thanks for pulling this together.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.