Skip to content

Spanish (Spain) translation#364

Merged
pull[bot] merged 0 commit intocodeigniter4:developfrom
treborin:develop
Aug 13, 2022
Merged

Spanish (Spain) translation#364
pull[bot] merged 0 commit intocodeigniter4:developfrom
treborin:develop

Conversation

@treborin
Copy link
Copy Markdown
Contributor

@treborin treborin commented Aug 11, 2022 •
edited by kenjis
Loading

Supersedes #357

@datamweb datamweb added duplicate This issue or pull request already exists enhancement New feature or request labels Aug 11, 2022
@treborin
Copy link
Copy Markdown
Contributor Author

treborin commented Aug 11, 2022

Hi @datamweb ,
Same issues with this second PR.
Please, let me know what can i do. I'll be here to upload files again whenever you find a solution.
Thanks for your help

@datamweb
Copy link
Copy Markdown
Collaborator

datamweb commented Aug 11, 2022

Hi @treborin,
I'm sorry you took the trouble to participate.
I will discuss this with my colleagues, it may take some time.
In any case we will tag you to know about the condition.

@datamweb datamweb added help wanted Extra attention is needed lang Languages file labels Aug 11, 2022
@kenjis kenjis removed the duplicate This issue or pull request already exists label Aug 11, 2022
kenjis
kenjis previously approved these changes Aug 11, 2022
View reviewed changes
@kenjis kenjis mentioned this pull request Aug 11, 2022
Closed
@kenjis kenjis dismissed their stale review August 11, 2022 21:51

Mistake

kenjis
kenjis requested changes Aug 11, 2022
View reviewed changes
Copy link
Copy Markdown
Member

@kenjis kenjis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please fix the file encoding.

@kenjis
Copy link
Copy Markdown
Member

kenjis commented Aug 13, 2022

There still is something wrong.

$ php -l src/Language/es/Auth.php 
PHP Fatal error:  Namespace declaration statement has to be the very first statement or after any declare call in the script in src/Language/es/Auth.php on line 3

Fatal error: Namespace declaration statement has to be the very first statement or after any declare call in the script in src/Language/es/Auth.php on line 3

Errors parsing src/Language/es/Auth.php

@kenjis
Copy link
Copy Markdown
Member

kenjis commented Aug 13, 2022 •
edited
Loading

@treborin Please remove the BOM.

--- a/src/Language/es/Auth.php
+++ b/src/Language/es/Auth.php
@@ -1,4 +1,4 @@
-<U+FEFF><?php
+<?php^M
 
 namespace CodeIgniter\Shield\Language\es;

@kenjis
Copy link
Copy Markdown
Member

kenjis commented Aug 13, 2022

And please remove ^M. That is the line break should be LF only, not CRLF.

@kenjis
Copy link
Copy Markdown
Member

kenjis commented Aug 13, 2022

Okay, thanks!

datamweb
datamweb requested changes Aug 13, 2022
View reviewed changes
Copy link
Copy Markdown
Collaborator

@datamweb datamweb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please change

@datamweb datamweb removed the help wanted Extra attention is needed label Aug 13, 2022
@datamweb
Copy link
Copy Markdown
Collaborator

datamweb commented Aug 13, 2022

@treborin,
Everything is fine, just fix this. (\ No newline at end of file)

@treborin
Copy link
Copy Markdown
Contributor Author

treborin commented Aug 13, 2022

@treborin, Everything is fine, just fix this. (\ No newline at end of file)

@datamweb , done!

@treborin
Copy link
Copy Markdown
Contributor Author

treborin commented Aug 13, 2022

wow!!! finally :)

datamweb
datamweb approved these changes Aug 13, 2022
View reviewed changes
Copy link
Copy Markdown
Collaborator

@datamweb datamweb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Roberto thank you for contributing with love to make Shield better.
Where there is love, there is pain.
Gracias!!

@pull pull bot merged commit 129afd9 into codeigniter4:develop Aug 13, 2022
@kenjis
Copy link
Copy Markdown
Member

kenjis commented Aug 13, 2022

@treborin Do you use "pull bot" ?
It seems "pull bot" deleted your PR branch.

Could you send this PR again?

@datamweb datamweb mentioned this pull request Aug 13, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kenjis kenjis kenjis approved these changes

@datamweb datamweb datamweb approved these changes

Assignees

No one assigned

Labels

enhancement New feature or request lang Languages file

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@treborin @datamweb @kenjis