Skip to content

fix: Shield ignores AuthToken::$authenticatorHeader config#1169

Merged
kenjis merged 1 commit intocodeigniter4:developfrom
alxjzx100:Bugfix-AuthToken-Hmac-config
Aug 17, 2024
Merged

fix: Shield ignores AuthToken::$authenticatorHeader config#1169
kenjis merged 1 commit intocodeigniter4:developfrom
alxjzx100:Bugfix-AuthToken-Hmac-config

Conversation

@alxjzx100
Copy link
Copy Markdown
Contributor

@alxjzx100 alxjzx100 commented Aug 15, 2024 •
edited
Loading

Description
Mentioned in discussion #1167
Fixes #1168

Checklist:

  • Securely signed commits
  • Component(s) with PHPDoc blocks, only if necessary or adds value
  • Unit testing, with >80% coverage
  • User guide updated
  • Conforms to style guide

@datamweb datamweb added GPG-Signing needed Pull requests that need GPG-Signing bug Something isn't working labels Aug 15, 2024
@datamweb datamweb changed the title Bugfix for the AuthToken and Hmac header line config. fix: for the AuthToken and Hmac header line config Aug 15, 2024
@datamweb
Copy link
Copy Markdown
Collaborator

datamweb commented Aug 15, 2024

See :

#672 (comment)
https://github.com/codeigniter4/CodeIgniter4/blob/develop/contributing/signing.md

@alxjzx100
Copy link
Copy Markdown
Contributor Author

alxjzx100 commented Aug 16, 2024

Signed, thank you.

@kenjis
Copy link
Copy Markdown
Member

kenjis commented Aug 16, 2024 •
edited
Loading

Please sign all your commits.
Screeshot 2024-08-16 11 16 37

Also, we don't like merge commits. Please do not include merge commits in PRs if you can.
You can use git rebase to remove the merge commit.
See https://github.com/codeigniter4/CodeIgniter4/blob/develop/contributing/workflow.md#updating-your-branch

@kenjis kenjis changed the title fix: for the AuthToken and Hmac header line config fix: Shield ignores AuthToken $authenticatorHeader config Aug 16, 2024
@kenjis kenjis changed the title fix: Shield ignores AuthToken $authenticatorHeader config fix: Shield ignores AuthToken::$authenticatorHeader config Aug 16, 2024
@kenjis kenjis changed the title fix: Shield ignores AuthToken::$authenticatorHeader config fix: Shield ignores AuthToken::$authenticatorHeader config Aug 16, 2024
@alxjzx100 alxjzx100 force-pushed the Bugfix-AuthToken-Hmac-config branch from b4447d2 to b70b0bd Compare August 16, 2024 02:23
datamweb
datamweb approved these changes Aug 16, 2024
View reviewed changes
Copy link
Copy Markdown
Collaborator

@datamweb datamweb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@datamweb datamweb removed the GPG-Signing needed Pull requests that need GPG-Signing label Aug 16, 2024
@kenjis kenjis merged commit 3214dfc into codeigniter4:develop Aug 17, 2024
@kenjis
Copy link
Copy Markdown
Member

kenjis commented Aug 17, 2024

@alxjzx100 Thank you!

@michalsn michalsn mentioned this pull request Jul 14, 2025
Merged
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kenjis kenjis kenjis approved these changes

@datamweb datamweb datamweb approved these changes

Assignees

No one assigned

Labels

bug Something isn't working

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Shield ignores $authenticatorHeader from AuthToken.php

3 participants

@alxjzx100 @datamweb @kenjis