fix: shield:user create does not assign a default group#1162
Merged
kenjis merged 1 commit intocodeigniter4:developfrom Aug 20, 2024
Merged
Conversation
datamweb
approved these changes
Aug 12, 2024
Collaborator
datamweb
left a comment
There was a problem hiding this comment.
lonnieezell say: instead of being forced into the default and then having to go to the database to change it.
In any case, I do not see any problem in the implementation.
Member
Author
|
Oh, I have not read the comment carefully. Thanks. And @bgeneto suggested |
Collaborator
I like this because of less user interactions. |
5 tasks
Member
Author
|
I sent a PR to implement |
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Supersedes #999
Fixes #998
The user registration form sets the default group value for the user when a new user is registered.
But the command
shield:user createdoes not set the default group.I think we should fix the inconsistency as a bug.
It would be nice, but nobody has implemented it. It can be implemented as enhancement later.
Checklist: