fix: Call to a member function getErrors() on null in CheckQueryReturnTrait

[kenjis]

Description
Fixes #1087

Since CI 4.5.0, $this->validation may be null.

Checklist:

• Securely signed commits
• Component(s) with PHPDoc blocks, only if necessary or adds value
• Unit testing, with >80% coverage
• User guide updated
• Conforms to style guide

[datamweb]

@kenjis How about this?

    protected function checkValidationError(): void
    {
        $validationErrors = $this->validation?->getErrors();

        if ($validationErrors !== [] && $validationErrors !== null) {
            $message = 'Validation error:';

            foreach ($validationErrors as $field => $error) {
                $message .= ' [' . $field . '] ' . $error;
            }

            throw new ValidationException($message);
        }
    }

[kenjis]

@datamweb Ah, if $this->validation is null, the model did not run validation.
So, your way is the way to go.

[kenjis]

$this->validation?->getErrors() requires PHP 8.0.
Shield still supports PHP 7.4.

shield/composer.json

Line 28 in 0894a16

"php": "^7.4.3 || ^8.0",

[datamweb]

Thanks, the code is more readable.

[datamweb]

Wait for a new version of Shield to be released, or temporarily use the develop branch:

composer require codeigniter4/shield:dev-develop

[quickdunk]

Thanks for this!