[Rector] Apply BooleanInIfConditionRuleFixerRector

[samsonasik]

Description

@kenjis @paulbalandan here based on #7943 (review)

I apply BooleanInIfConditionRuleFixerRector to ensure pass bool to if cond.

Checklist:

• Securely signed commits
• Component(s) with PHPDoc blocks, only if necessary or adds value
• Unit testing, with >80% coverage
• User guide updated
• Conforms to style guide

[samsonasik]

@kenjis updated 👍

[samsonasik]

phpstan baseline regenerated 👍

[samsonasik]

@kenjis updated 👍

[samsonasik]

should be ready for merge 👍

It would be better to remove conditions that are not necessary.

[github-actions]

👋 Hi, @samsonasik!

We detected conflicts in your PR against the base branch 🙊
You may want to sync 🔄 your branch with upstream!

Ref: Syncing Your Branch

[MGatner]

@samsonasik I think this is a good direction to go but will need some more individual attention to the changes. Please review @paulbalandan and @kenjis suggestions.

[samsonasik]

@kenjis @paulbalandan the type check is based on type defined in param, so that check fix also phpstan, except, we use assert before if to enforce type.

[kenjis]

@samsonasik Can you update the PR branch, and run rector again?

[samsonasik]

@kenjis done 👍

[samsonasik]

@kenjis updated 👍

[kenjis]

Please run to remove ignoreErrors.

$ vendor/bin/phpstan analyze --generate-baseline phpstan-baseline.php

[kenjis]

Run vendor/bin/rector process system/CLI/CLI.php first, and run phpstan to update the baseline.

[samsonasik]

@kenjis done 👍

[kenjis]

@samsonasik Thank you! 👍
PHPStan and Rector check have passed.
I'm going to merge this after all checks have passed.

[samsonasik]

Ready to merge 👍