fix: check for CSRF token in the raw body#7915
Merged
kenjis merged 7 commits intocodeigniter4:developfrom Sep 18, 2023
Merged
Conversation
samsonasik
reviewed
Sep 9, 2023
kenjis
reviewed
Sep 9, 2023
bc4b54e to
1481461
Compare
kenjis
reviewed
Sep 11, 2023
kenjis
reviewed
Sep 11, 2023
MGatner
reviewed
Sep 12, 2023
Member
MGatner
left a comment
There was a problem hiding this comment.
Looks good pending Kenjis comments.
1481461 to
5734dd3
Compare
5734dd3 to
be07d9c
Compare
Member
Author
|
I have no idea what the PHPStan error means because every occurrence of |
Member
|
@michalsn run |
Member
Author
|
@paulbalandan Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
CSRF check for PUT, PATCH, and DELETE type of requests is made only for JSON data. This PR fixes that by adding the raw input data to check.
Checklist: