Skip to content

docs: fix or remove @param#7879

Merged
kenjis merged 1 commit intocodeigniter4:developfrom
kenjis:docs-phpdoc-param
Aug 30, 2023
Merged

docs: fix or remove @param#7879
kenjis merged 1 commit intocodeigniter4:developfrom
kenjis:docs-phpdoc-param

Conversation

@kenjis
Copy link
Copy Markdown
Member

@kenjis kenjis commented Aug 30, 2023

Description
php-cs-fixer has been modified to remove these tags.

  23) tests/_support/Config/Services.php (no_superfluous_phpdoc_tags, phpdoc_trim_consecutive_blank_line_separation)
      ---------- begin diff ----------
--- /home/runner/work/CodeIgniter4/CodeIgniter4/tests/_support/Config/Services.php
+++ /home/runner/work/CodeIgniter4/CodeIgniter4/tests/_support/Config/Services.php
@@ -28,8 +28,6 @@
     /**
      * The URI class provides a way to model and manipulate URIs.
      *
-     * @param string $uri
-     *
      * @return URI
      */
     public static function uri(?string $uri = null, bool $getShared = true)

      ----------- end diff -----------


Found 23 of 875 files that can be fixed in 92.546 seconds, 46.000 MB memory used
Error: Process completed with exit code 8.

See https://github.com/codeigniter4/CodeIgniter4/actions/runs/6018752536/job/16327489927#step:8:487

Checklist:

  • Securely signed commits
  • Component(s) with PHPDoc blocks, only if necessary or adds value
  • [] Unit testing, with >80% coverage
  • [] User guide updated
  • Conforms to style guide

php-cs-fixer has been modified to remove these tags.
@kenjis kenjis merged commit f7e6cff into codeigniter4:develop Aug 30, 2023
@kenjis kenjis deleted the docs-phpdoc-param branch August 30, 2023 01:23
@kenjis
Copy link
Copy Markdown
Member Author

kenjis commented Aug 30, 2023

Thank you! @paulbalandan

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants