Skip to content

fix: add types for cache handlers#7858

Merged
kenjis merged 1 commit intocodeigniter4:developfrom
paulbalandan:phpstan-cache-types
Aug 26, 2023
Merged

fix: add types for cache handlers#7858
kenjis merged 1 commit intocodeigniter4:developfrom
paulbalandan:phpstan-cache-types

Conversation

@paulbalandan
Copy link
Copy Markdown
Member

@paulbalandan paulbalandan commented Aug 25, 2023

Description
See #7731

Checklist:

  • Securely signed commits
  • Component(s) with PHPDoc blocks, only if necessary or adds value
  • Unit testing, with >80% coverage
  • User guide updated
  • Conforms to style guide

Copy link
Copy Markdown
Member

@kenjis kenjis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@kenjis kenjis merged commit 1f09614 into codeigniter4:develop Aug 26, 2023
@paulbalandan paulbalandan deleted the phpstan-cache-types branch August 26, 2023 02:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants