Skip to content

use shared gh action#57

Merged
olamy merged 3 commits into
masterfrom
shared-gh-action
May 18, 2022
Merged

use shared gh action#57
olamy merged 3 commits into
masterfrom
shared-gh-action

Conversation

@olamy
Copy link
Copy Markdown
Member

@olamy olamy commented May 12, 2022

No description provided.

@olamy olamy added the build label May 12, 2022
jdk-matrix: '["11", "17"]'
jdk-distribution-matrix: '["zulu", "temurin", "microsoft", "liberica"]'
os-matrix: '["ubuntu-latest","windows-latest", "macOS-latest"]'
maven_args: 'install javadoc:javadoc -e -B -V -fae '
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why need install?

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why not? it's a temporary node so doesn't hurt anybody :)

jdk-fast-fail-build: '11'
jdk-matrix: '["11", "17"]'
jdk-distribution-matrix: '["zulu", "temurin", "microsoft", "liberica"]'
os-matrix: '["ubuntu-latest","windows-latest", "macOS-latest"]'
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the same as default

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

default has more jdks

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@slawekjaranowski And default in master are changed without PRs neither asking around

@olamy olamy merged commit 97c20b4 into master May 18, 2022
@olamy olamy deleted the shared-gh-action branch May 18, 2022 11:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants